linux-kernel - [PATCH] HID: remove superfluous (and wrong) Makefile entry for CONFIG_INTEL_ISH_FIRMWARE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <54o2s270-779o-q635-37o5-7s0o11o74o25@xreary.bet>
Date: Wed, 12 Mar 2025 09:08:22 +0100 (CET)
From: Jiri Kosina <jikos@...nel.org>
To: Benjamin Tissoires <bentiss@...nel.org>, 
    Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>, 
    Nick Crews <ncrews@...omium.org>, Jett Rink <jettrink@...omium.org>
cc: Jiri Slaby <jirislaby@...nel.org>, linux-kernel@...r.kernel.org, 
    linux-input@...r.kernel.org
Subject: [PATCH] HID: remove superfluous (and wrong) Makefile entry for
 CONFIG_INTEL_ISH_FIRMWARE_DOWNLOADER

From: Jiri Kosina <jkosina@...e.com>

The line

	obj-$(INTEL_ISH_FIRMWARE_DOWNLOADER)   += intel-ish-hid/

in top-level HID Makefile is both superfluous (as CONFIG_INTEL_ISH_FIRMWARE_DOWNLOADER
depends on CONFIG_INTEL_ISH_HID, which contains intel-ish-hid/ already) and wrong (as it's
missing the CONFIG_ prefix).

Just remove it.

Reported-by: Jiri Slaby <jirislaby@...nel.org>
Fixes: 91b228107da3e ("HID: intel-ish-hid: ISH firmware loader client driver")
Signed-off-by: Jiri Kosina <jkosina@...e.com>
---
 drivers/hid/Makefile | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/hid/Makefile b/drivers/hid/Makefile
index 482b096eea28..0abfe51704a0 100644
--- a/drivers/hid/Makefile
+++ b/drivers/hid/Makefile
@@ -166,7 +166,6 @@ obj-$(CONFIG_USB_KBD)		+= usbhid/
 obj-$(CONFIG_I2C_HID_CORE)	+= i2c-hid/
 
 obj-$(CONFIG_INTEL_ISH_HID)	+= intel-ish-hid/
-obj-$(INTEL_ISH_FIRMWARE_DOWNLOADER)	+= intel-ish-hid/
 
 obj-$(CONFIG_AMD_SFH_HID)       += amd-sfh-hid/
 
-- 
2.43.0