linux-kernel - Re: [PATCH] HID: remove superfluous (and wrong) Makefile entry for CONFIG_INTEL_ISH_FIRMWARE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <fa3a518291e7b122f078099b44a9c4a785567a89.camel@linux.intel.com>
Date: Wed, 12 Mar 2025 08:38:46 -0700
From: srinivas pandruvada <srinivas.pandruvada@...ux.intel.com>
To: Jiri Kosina <jikos@...nel.org>, Benjamin Tissoires <bentiss@...nel.org>,
  Nick Crews <ncrews@...omium.org>, Jett Rink <jettrink@...omium.org>
Cc: Jiri Slaby <jirislaby@...nel.org>, linux-kernel@...r.kernel.org, 
	linux-input@...r.kernel.org
Subject: Re: [PATCH] HID: remove superfluous (and wrong) Makefile entry for
 CONFIG_INTEL_ISH_FIRMWARE_DOWNLOADER

On Wed, 2025-03-12 at 09:08 +0100, Jiri Kosina wrote:
> From: Jiri Kosina <jkosina@...e.com>
> 
> The line
> 
> 	obj-$(INTEL_ISH_FIRMWARE_DOWNLOADER)   += intel-ish-hid/
> 
> in top-level HID Makefile is both superfluous (as
> CONFIG_INTEL_ISH_FIRMWARE_DOWNLOADER
> depends on CONFIG_INTEL_ISH_HID, which contains intel-ish-hid/
> already) and wrong (as it's
> missing the CONFIG_ prefix).
> 
> Just remove it.
> 
> Reported-by: Jiri Slaby <jirislaby@...nel.org>
> Fixes: 91b228107da3e ("HID: intel-ish-hid: ISH firmware loader client
> driver")
> Signed-off-by: Jiri Kosina <jkosina@...e.com>

Good one

Acked-by: Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>

Thanks,
Srinivas

> ---
>  drivers/hid/Makefile | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/hid/Makefile b/drivers/hid/Makefile
> index 482b096eea28..0abfe51704a0 100644
> --- a/drivers/hid/Makefile
> +++ b/drivers/hid/Makefile
> @@ -166,7 +166,6 @@ obj-$(CONFIG_USB_KBD)		+= usbhid/
>  obj-$(CONFIG_I2C_HID_CORE)	+= i2c-hid/
>  
>  obj-$(CONFIG_INTEL_ISH_HID)	+= intel-ish-hid/
> -obj-$(INTEL_ISH_FIRMWARE_DOWNLOADER)	+= intel-ish-hid/
>  
>  obj-$(CONFIG_AMD_SFH_HID)       += amd-sfh-hid/
>