linux-kernel - Re: [PATCH] arm64: dts: qcom: qcs8300: add the pcie smmu node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <rj4jtqchuetrbtczbhvaa5hcp5olumwdbao3x4pulkxiqcq2ag@v6ftffk6bcc5>
Date: Wed, 12 Mar 2025 10:44:10 +0200
From: Dmitry Baryshkov <lumag@...nel.org>
To: Pratyush Brahma <quic_pbrahma@...cinc.com>
Cc: Bjorn Andersson <andersson@...nel.org>, 
	Konrad Dybcio <konradybcio@...nel.org>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arm64: dts: qcom: qcs8300: add the pcie smmu node

On Wed, Mar 12, 2025 at 12:41:38PM +0530, Pratyush Brahma wrote:
> 
> On 3/12/2025 12:23 PM, Dmitry Baryshkov wrote:
> > On Thu, Feb 06, 2025 at 07:13:17PM +0530, Pratyush Brahma wrote:
> > > Add the PCIe SMMU node to enable address translations
> > > for pcie.
> > > 
> > > Signed-off-by: Pratyush Brahma <quic_pbrahma@...cinc.com>
> > > ---
> > >   arch/arm64/boot/dts/qcom/qcs8300.dtsi | 75 +++++++++++++++++++++++++++++++++++
> > >   1 file changed, 75 insertions(+)
> > > 
> > Reviewed-by: Dmitry Baryshkov <lumag@...nel.org>
> > 
> > Though I see a little benefit in having this SMMU node if it is not
> > followed by the PCIe enablement.
> 
> Thanks for the review!
> 
> PCIe enablement changes for qcs8300 have been posted already [1] and [1]
> needs
> this patch as mentioned in [2].

Ack. In future please consider posting series in a logical way: if PCIe
SMMU is only useful for PCIe and it is required for PCIe to work it
makes much more sense to have it as a part of the PCIe enablement series
rather than having it as a separate patch which can easily get lost.

> 
> [1] https://lore.kernel.org/lkml/20250310063103.3924525-8-quic_ziyuzhan@quicinc.com
> [2] https://lore.kernel.org/lkml/20250310063103.3924525-1-quic_ziyuzhan@quicinc.com
> 
> -- 
> Thanks and Regards
> Pratyush Brahma
> 

-- 
With best wishes
Dmitry