linux-kernel - Re: [PATCH v4] dma-engine: sun4i: Use devm functions in probe()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <81f87d39-d3f8-4b6a-91cb-b0177d34171b@prolan.hu>
Date: Wed, 12 Mar 2025 09:53:04 +0100
From: Csókás Bence <csokas.bence@...lan.hu>
To: Markus Elfring <Markus.Elfring@....de>, <dmaengine@...r.kernel.org>,
	<linux-sunxi@...ts.linux.dev>, <linux-arm-kernel@...ts.infradead.org>,
	Chen-Yu Tsai <wens@...e.org>, Jernej Skrabec <jernej.skrabec@...il.com>
CC: LKML <linux-kernel@...r.kernel.org>, Chen-Yu Tsai <wens@...nel.org>,
	Samuel Holland <samuel@...lland.org>, Vinod Koul <vkoul@...nel.org>
Subject: Re: [PATCH v4] dma-engine: sun4i: Use devm functions in probe()

Dear Markus,

On 2025. 03. 11. 20:33, Markus Elfring wrote:
 >> Clean up error handling by using devm functions
 >> and dev_err_probe(). This should make it easier
 > …
 >
 > You may occasionally put more than 47 characters into text lines
 > of such a change description.

It was an old patch I hadn't yet reformatted to 75 cols. I used 50-60 
cols before, because my mail client's preview panel is very narrow, so 
anything more than ~65 characters will wrap. If there will be a v5, I'll 
reformat it to 75 cols as well, as per the style guidelines.

> How good does such a change combination fit to the patch requirement
> according to separation of concerns?
> https://web.git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.14-rc6#n81

It is a general refactor patch, it shouldn't change any functionality. I 
could split it to one part introducing `devm_clk_get_enabled()` and the 
other `dmaenginem_async_device_register()`, but I don't feel that to be 
necessary, nor does it bring any advantages I believe.

> Regards,
> Markus

Bence