linux-kernel - Re: [PATCH] mmc: sdhci-omap: Disable MMC_CAP_AGGRESSIVE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6d33b6fb-94a2-4740-9247-b51f9bc9feab@intel.com>
Date: Wed, 12 Mar 2025 15:25:55 +0200
From: Adrian Hunter <adrian.hunter@...el.com>
To: Ulf Hansson <ulf.hansson@...aro.org>, <linux-mmc@...r.kernel.org>,
	"Vignesh Raghavendra" <vigneshr@...com>
CC: Tony Lindgren <tony@...mide.com>, David Owens <daowens01@...il.com>,
	Robert Nelson <robertcnelson@...il.com>, Romain Naour
	<romain.naour@...le.fr>, Andrei Aldea <andrei@...com>, Judith Mendez
	<jm@...com>, <linux-omap@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<stable@...r.kernel.org>
Subject: Re: [PATCH] mmc: sdhci-omap: Disable MMC_CAP_AGGRESSIVE_PM for
 eMMC/SD

On 12/03/25 14:17, Ulf Hansson wrote:
> We have received reports about cards can become corrupt related to the
> aggressive PM support. Let's make a partial revert of the change that
> enabled the feature.
> 
> Reported-by: David Owens <daowens01@...il.com>
> Reported-by: Romain Naour <romain.naour@...le.fr>
> Reported-by: Robert Nelson <robertcnelson@...il.com>
> Tested-by: Robert Nelson <robertcnelson@...il.com>
> Fixes: 3edf588e7fe0 ("mmc: sdhci-omap: Allow SDIO card power off and enable aggressive PM")
> Cc: stable@...r.kernel.org
> Signed-off-by: Ulf Hansson <ulf.hansson@...aro.org>

Acked-by: Adrian Hunter <adrian.hunter@...el.com>


> ---
>  drivers/mmc/host/sdhci-omap.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/mmc/host/sdhci-omap.c b/drivers/mmc/host/sdhci-omap.c
> index 54d795205fb4..26a9a8b5682a 100644
> --- a/drivers/mmc/host/sdhci-omap.c
> +++ b/drivers/mmc/host/sdhci-omap.c
> @@ -1339,8 +1339,8 @@ static int sdhci_omap_probe(struct platform_device *pdev)
>  	/* R1B responses is required to properly manage HW busy detection. */
>  	mmc->caps |= MMC_CAP_NEED_RSP_BUSY;
>  
> -	/* Allow card power off and runtime PM for eMMC/SD card devices */
> -	mmc->caps |= MMC_CAP_POWER_OFF_CARD | MMC_CAP_AGGRESSIVE_PM;
> +	/*  Enable SDIO card power off. */
> +	mmc->caps |= MMC_CAP_POWER_OFF_CARD;
>  
>  	ret = sdhci_setup_host(host);
>  	if (ret)