linux-kernel - Re: [PATCH] mmc: sdhci-omap: Disable MMC_CAP_AGGRESSIVE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAOCHtYjGuw9szeChihrDZ39_2+w5xOverbp6mAjjLjR=QkK1zg@mail.gmail.com>
Date: Sun, 16 Mar 2025 15:54:03 -0500
From: Robert Nelson <robertcnelson@...il.com>
To: Ulf Hansson <ulf.hansson@...aro.org>
Cc: linux-mmc@...r.kernel.org, Adrian Hunter <adrian.hunter@...el.com>, 
	Vignesh Raghavendra <vigneshr@...com>, Tony Lindgren <tony@...mide.com>, David Owens <daowens01@...il.com>, 
	Romain Naour <romain.naour@...le.fr>, Andrei Aldea <andrei@...com>, Judith Mendez <jm@...com>, 
	linux-omap@...r.kernel.org, linux-kernel@...r.kernel.org, 
	stable@...r.kernel.org
Subject: Re: [PATCH] mmc: sdhci-omap: Disable MMC_CAP_AGGRESSIVE_PM for eMMC/SD

On Wed, Mar 12, 2025 at 7:17 AM Ulf Hansson <ulf.hansson@...aro.org> wrote:
>
> We have received reports about cards can become corrupt related to the
> aggressive PM support. Let's make a partial revert of the change that
> enabled the feature.
>
> Reported-by: David Owens <daowens01@...il.com>
> Reported-by: Romain Naour <romain.naour@...le.fr>
> Reported-by: Robert Nelson <robertcnelson@...il.com>
> Tested-by: Robert Nelson <robertcnelson@...il.com>
> Fixes: 3edf588e7fe0 ("mmc: sdhci-omap: Allow SDIO card power off and enable aggressive PM")
> Cc: stable@...r.kernel.org
> Signed-off-by: Ulf Hansson <ulf.hansson@...aro.org>
> ---
>  drivers/mmc/host/sdhci-omap.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci-omap.c b/drivers/mmc/host/sdhci-omap.c
> index 54d795205fb4..26a9a8b5682a 100644
> --- a/drivers/mmc/host/sdhci-omap.c
> +++ b/drivers/mmc/host/sdhci-omap.c
> @@ -1339,8 +1339,8 @@ static int sdhci_omap_probe(struct platform_device *pdev)
>         /* R1B responses is required to properly manage HW busy detection. */
>         mmc->caps |= MMC_CAP_NEED_RSP_BUSY;
>
> -       /* Allow card power off and runtime PM for eMMC/SD card devices */
> -       mmc->caps |= MMC_CAP_POWER_OFF_CARD | MMC_CAP_AGGRESSIVE_PM;
> +       /*  Enable SDIO card power off. */
> +       mmc->caps |= MMC_CAP_POWER_OFF_CARD;
>
>         ret = sdhci_setup_host(host);
>         if (ret)
> --
> 2.43.0
>

Thanks Ulf, i also have this exact revert running on the target in our
ci farm, i think we should be good.  But I'll validate it in 4 weeks!

Regards,

-- 
Robert Nelson
https://rcn-ee.com/