linux-kernel - RE: [External] Re: [PATCH 04/10] dt-bindings: riscv: Add SiFive HiFive Premier P550 board

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <SA3PR04MB893109C2F7D6DB3B0499B0AC83D02@SA3PR04MB8931.namprd04.prod.outlook.com>
Date: Wed, 12 Mar 2025 14:25:17 +0000
From: Pinkesh Vaghela <pinkesh.vaghela@...fochips.com>
To: Krzysztof Kozlowski <krzk@...nel.org>, Conor Dooley <conor@...nel.org>,
	Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Thomas Gleixner <tglx@...utronix.de>
CC: Paul Walmsley <paul.walmsley@...ive.com>, Samuel Holland
	<samuel.holland@...ive.com>, Palmer Dabbelt <palmer@...belt.com>, Albert Ou
	<aou@...s.berkeley.edu>, Daniel Lezcano <daniel.lezcano@...aro.org>, Min Lin
	<linmin@...incomputing.com>, Pritesh Patel <pritesh.patel@...fochips.com>,
	Yangyu Chen <cyy@...self.name>, Lad Prabhakar
	<prabhakar.mahadev-lad.rj@...renesas.com>, Yu Chien Peter Lin
	<peterlin@...estech.com>, Charlie Jenkins <charlie@...osinc.com>, Kanak
 Shilledar <kanakshilledar@...il.com>, Darshan Prajapati
	<darshan.prajapati@...fochips.com>, Neil Armstrong
	<neil.armstrong@...aro.org>, Heiko Stuebner <heiko@...ech.de>, Aradhya Bhatia
	<a-bhatia1@...com>, "rafal@...ecki.pl" <rafal@...ecki.pl>, Anup Patel
	<anup@...infault.org>, "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>, "linux-riscv@...ts.infradead.org"
	<linux-riscv@...ts.infradead.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
Subject: RE: [External] Re: [PATCH 04/10] dt-bindings: riscv: Add SiFive
 HiFive Premier P550 board

Hi Krzysztof,

On Tue, Mar 12, 2025 at 12:55:52PM +0530, Krzysztof Kozlowski wrote: 
> On 11/03/2025 08:34, Pinkesh Vaghela wrote:
> > From: Pritesh Patel <pritesh.patel@...fochips.com>
> >
> > Add DT binding documentation for the ESWIN EIC7700 SoC and HiFive
> > Premier P550 Board
> >
> > Signed-off-by: Pritesh Patel <pritesh.patel@...fochips.com>
> > Reviewed-by: Samuel Holland <samuel.holland@...ive.com>
> 
> 
> This Rb tag appears everywhere, while this is a v1 and it was not given on the
> lists, so I want to be sure this was not some blank tag added to series because
> someone said "yeah, lgtm". Was it really review as in *reviewers statement of
> oversight*?

The "Reviewed-by" tag was added because we had a thorough review of all the
patches from Samuel Holland before posting.

> 
> > Signed-off-by: Pinkesh Vaghela <pinkesh.vaghela@...fochips.com>
> > ---
> ..
> 
> 
> > +
> > +...
> > diff --git a/MAINTAINERS b/MAINTAINERS index
> > 25c86f47353d..901d0e0adb25 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -8572,6 +8572,12 @@ L:     linux-can@...r.kernel.org
> >  S:   Maintained
> >  F:   drivers/net/can/usb/esd_usb.c
> >
> > +ESWIN DEVICETREES
> > +M:   Min Lin <linmin@...incomputing.com>
> > +M:   Pinkesh Vaghela <pinkesh.vaghela@...fochips.com>
> > +M:   Pritesh Patel <pritesh.patel@...fochips.com>
> > +S:   Maintained
> 
> If you add this entry here, then add the path for the eswin binding.

Thanks for the feedback. I will add this in v2.

Regards,
Pinkesh

> 
> Best regards,
> Krzysztof