linux-kernel - Re: [PATCH] nls: Fix utf32_to_utf8 parameter type in declaration and definition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1e8a650d-dd87-4ff3-ad83-da9e7f33a915@oss.qualcomm.com>
Date: Thu, 13 Mar 2025 08:52:52 -0700
From: Jeff Johnson <jeff.johnson@....qualcomm.com>
To: ye.xingchen@....com.cn, brauner@...nel.org
Cc: jack@...e.cz, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] nls: Fix utf32_to_utf8 parameter type in declaration and
 definition

On 3/13/2025 1:01 AM, ye.xingchen@....com.cn wrote:
> From: YeXingchen <ye.xingchen@....com.cn>
> 
> The declaration of utf32_to_utf8 in the header file uses
> bool maxlen as the parameter type, while the definition uses bool maxout.
> 
> This patch aligns the parameter name in the definition with the
> declaration,changing maxout to maxlen to ensure consistency.
> 
> Signed-off-by: YeXingchen <ye.xingchen@....com.cn>
> ---
>  fs/nls/nls_base.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/nls/nls_base.c b/fs/nls/nls_base.c
> index 18d597e49a19..1dc2f8c8916e 100644
> --- a/fs/nls/nls_base.c
> +++ b/fs/nls/nls_base.c
> @@ -83,7 +83,7 @@ int utf8_to_utf32(const u8 *s, int inlen, unicode_t *pu)
>  }
>  EXPORT_SYMBOL(utf8_to_utf32);
> 
> -int utf32_to_utf8(unicode_t u, u8 *s, int maxout)
> +int utf32_to_utf8(unicode_t u, u8 *s, int maxlen)
>  {
>  	unsigned long l;
>  	int c, nc;

It is obvious you didn't compile this code since the implementation still uses
maxout. Note that a less intrusive change would be to rename parameters in the
prototype.