linux-kernel - Re: [PATCH v4 00/14] Add support for suppressing warning backtraces

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250313-abiding-vivid-robin-159dfa@houat>
Date: Thu, 13 Mar 2025 18:24:25 +0100
From: Maxime Ripard <mripard@...nel.org>
To: Kees Cook <kees@...nel.org>
Cc: Alessandro Carminati <acarmina@...hat.com>, 
	linux-kselftest@...r.kernel.org, David Airlie <airlied@...il.com>, Arnd Bergmann <arnd@...db.de>, 
	Maíra Canal <mcanal@...lia.com>, Dan Carpenter <dan.carpenter@...aro.org>, 
	Daniel Diaz <daniel.diaz@...aro.org>, David Gow <davidgow@...gle.com>, 
	Arthur Grillo <arthurgrillo@...eup.net>, Brendan Higgins <brendan.higgins@...ux.dev>, 
	Naresh Kamboju <naresh.kamboju@...aro.org>, Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>, 
	Andrew Morton <akpm@...ux-foundation.org>, Ville Syrjälä <ville.syrjala@...ux.intel.com>, 
	Daniel Vetter <daniel@...ll.ch>, Thomas Zimmermann <tzimmermann@...e.de>, 
	Guenter Roeck <linux@...ck-us.net>, Alessandro Carminati <alessandro.carminati@...il.com>, 
	Jani Nikula <jani.nikula@...el.com>, dri-devel@...ts.freedesktop.org, kunit-dev@...glegroups.com, 
	linux-arch@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, linux-doc@...r.kernel.org, 
	linux-kernel@...r.kernel.org, linux-parisc@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org, 
	linux-riscv@...ts.infradead.org, linux-s390@...r.kernel.org, linux-sh@...r.kernel.org, 
	loongarch@...ts.linux.dev, x86@...nel.org
Subject: Re: [PATCH v4 00/14] Add support for suppressing warning backtraces

Hi,

On Thu, Mar 13, 2025 at 10:17:49AM -0700, Kees Cook wrote:
> On Thu, Mar 13, 2025 at 11:43:15AM +0000, Alessandro Carminati wrote:
> > Some unit tests intentionally trigger warning backtraces by passing bad
> > parameters to kernel API functions. Such unit tests typically check the
> > return value from such calls, not the existence of the warning backtrace.
> 
> Thanks for picking this series back up! I honestly thought this had
> already landed. :)
> 
> > With CONFIG_KUNIT enabled, image size increase with this series applied is
> > approximately 1%. The image size increase (and with it the functionality
> > introduced by this series) can be avoided by disabling
> > CONFIG_KUNIT_SUPPRESS_BACKTRACE.
> 
> Yeah, as with my prior review, I'm a fan of this. It makes a bunch of my
> very noisy tests much easier to deal with.

And for the record, we're also affected by this in DRM and would very
much like to get it merged in one shape or another.

Maxime

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)