linux-kernel - Re: [PATCH 2/2] ARM: add KEEP() keyword to ARM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdatTYZ9oxSBdjTbs-LjF3ONqcA-9vYojPc-KSGZmoEO=A@mail.gmail.com>
Date: Thu, 13 Mar 2025 09:49:06 +0100
From: Linus Walleij <linus.walleij@...aro.org>
To: Nathan Chancellor <nathan@...nel.org>
Cc: Russell King <linux@...linux.org.uk>, Christian Eggers <ceggers@...i.de>, 
	Arnd Bergmann <arnd@...db.de>, Yuntao Liu <liuyuntao12@...wei.com>, 
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org, 
	llvm@...ts.linux.dev, stable@...r.kernel.org
Subject: Re: [PATCH 2/2] ARM: add KEEP() keyword to ARM_VECTORS

On Tue, Mar 11, 2025 at 8:44 PM Nathan Chancellor <nathan@...nel.org> wrote:

> From: Christian Eggers <ceggers@...i.de>
>
> Without this, the vectors are removed if LD_DEAD_CODE_DATA_ELIMINATION
> is enabled.  At startup, the CPU (silently) hangs in the undefined
> instruction exception as soon as the first timer interrupt arrives.
>
> On my setup, the system also boots fine without the 2nd and 3rd KEEP()
> statements, so I cannot tell whether these are actually required.
>
> Cc: stable@...r.kernel.org
> Fixes: ed0f94102251 ("ARM: 9404/1: arm32: enable HAVE_LD_DEAD_CODE_DATA_ELIMINATION")
> Signed-off-by: Christian Eggers <ceggers@...i.de>
> [nathan: Use OVERLAY_KEEP() to avoid breaking old ld.lld versions]
> Signed-off-by: Nathan Chancellor <nathan@...nel.org>

Reviewed-by: Linus Walleij <linus.walleij@...aro.org>

Yours,
Linus Walleij