linux-kernel - Re: [PATCH v13 1/4] dt-bindings: PCI: qcom: Add MHI registers for IPQ9574

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1c88f01b-4414-4f02-91ed-572a9261543a@kernel.org>
Date: Thu, 13 Mar 2025 12:01:54 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Varadarajan Narayanan <quic_varada@...cinc.com>, bhelgaas@...gle.com,
 lpieralisi@...nel.org, kw@...ux.com, manivannan.sadhasivam@...aro.org,
 robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org,
 andersson@...nel.org, konradybcio@...nel.org, linux-arm-msm@...r.kernel.org,
 linux-pci@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v13 1/4] dt-bindings: PCI: qcom: Add MHI registers for
 IPQ9574

On 13/03/2025 09:05, Varadarajan Narayanan wrote:
> Append the MHI register range to IPQ9574. This is an optional range used

Same question, you still did not answer - does hardware have this range?
Which hardware has it?

I pointed out that you affect at least two other variants. Your commit
msg must explain that. For example what if they do not have this range?
Then this change is just wrong.

Start documenting the hardware, not your drivers.

Best regards,
Krzysztof