[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Z9LGti0cdg9Sj6xa@hu-varada-blr.qualcomm.com>
Date: Thu, 13 Mar 2025 17:21:18 +0530
From: Varadarajan Narayanan <quic_varada@...cinc.com>
To: Krzysztof Kozlowski <krzk@...nel.org>
CC: <bhelgaas@...gle.com>, <lpieralisi@...nel.org>, <kw@...ux.com>,
<manivannan.sadhasivam@...aro.org>, <robh@...nel.org>,
<krzk+dt@...nel.org>, <conor+dt@...nel.org>, <andersson@...nel.org>,
<konradybcio@...nel.org>, <linux-arm-msm@...r.kernel.org>,
<linux-pci@...r.kernel.org>, <devicetree@...r.kernel.org>,
<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v13 1/4] dt-bindings: PCI: qcom: Add MHI registers for
IPQ9574
On Thu, Mar 13, 2025 at 12:01:54PM +0100, Krzysztof Kozlowski wrote:
> On 13/03/2025 09:05, Varadarajan Narayanan wrote:
> > Append the MHI register range to IPQ9574. This is an optional range used
>
> Same question, you still did not answer - does hardware have this range?
> Which hardware has it?
Yes. All three (ipq6018, ipq8074, ipq9574) have this range.
> I pointed out that you affect at least two other variants. Your commit
> msg must explain that. For example what if they do not have this range?
> Then this change is just wrong.
>
> Start documenting the hardware, not your drivers.
Since all three have this range will this commit message be ok?
Append the MHI register range to ipq6018, ipq8074-gen3 & ipq9574. This
is an optional range used by the dwc controller driver to print debug
stats via the debugfs file 'link_transition_count'.
Additionally, should I update ipq6018.dtsi and ipq8074.dtsi also and include in
this patchset?
Thanks
Varada
Powered by blists - more mailing lists