linux-kernel - Re: [PATCH net-next 4/4] net/mlx5e: Expose port reset cycle recovery counter via ethtool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z9Q9wBuDYHvEc4zY@mini-arch>
Date: Fri, 14 Mar 2025 07:31:28 -0700
From: Stanislav Fomichev <stfomichev@...il.com>
To: Tariq Toukan <tariqt@...dia.com>
Cc: "David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Andrew Lunn <andrew+netdev@...n.ch>, Gal Pressman <gal@...dia.com>,
	Mark Bloch <mbloch@...dia.com>, Moshe Shemesh <moshe@...dia.com>,
	Saeed Mahameed <saeedm@...dia.com>,
	Leon Romanovsky <leon@...nel.org>, Jonathan Corbet <corbet@....net>,
	netdev@...r.kernel.org, linux-rdma@...r.kernel.org,
	linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
	Yael Chemla <ychemla@...dia.com>
Subject: Re: [PATCH net-next 4/4] net/mlx5e: Expose port reset cycle recovery
 counter via ethtool

On 03/13, Tariq Toukan wrote:
> From: Yael Chemla <ychemla@...dia.com>
> 
> Display recovery event of PPCNT recovery counters group. Counts (per
> link) the number of total successful recovery events of any recovery
> types during port reset cycle.
> 
> Signed-off-by: Yael Chemla <ychemla@...dia.com>
> Reviewed-by: Cosmin Ratiu <cratiu@...dia.com>
> Signed-off-by: Tariq Toukan <tariqt@...dia.com>
> ---
>  .../ethernet/mellanox/mlx5/counters.rst       |  5 +++
>  .../ethernet/mellanox/mlx5/core/en_stats.c    | 44 ++++++++++++++++---
>  .../ethernet/mellanox/mlx5/core/en_stats.h    |  4 ++
>  3 files changed, 48 insertions(+), 5 deletions(-)
> 
> diff --git a/Documentation/networking/device_drivers/ethernet/mellanox/mlx5/counters.rst b/Documentation/networking/device_drivers/ethernet/mellanox/mlx5/counters.rst
> index 99d95be4d159..f9a1cf370b5a 100644
> --- a/Documentation/networking/device_drivers/ethernet/mellanox/mlx5/counters.rst
> +++ b/Documentation/networking/device_drivers/ethernet/mellanox/mlx5/counters.rst
> @@ -1082,6 +1082,11 @@ like flow control, FEC and more.
>         need to replace the cable/transceiver.
>       - Error
>  
> +  * - `total_success_recovery_phy`
> +     - The number of total successful recovery events of any type during
> +       ports reset cycle.
> +     - Error
> +

html build complains with the following:
Sphinx parallel build error:
docutils.utils.SystemMessagePropagation: <system_message level="3" line="896" source="/home/doc-build/testing/Documentation/networking/device_drivers/ethernet/mellanox/mlx5/counters.rst" type="ERROR"><paragraph>Error parsing content block for the "flat-table" directive: exactly one bullet list expected.</paragraph><literal_block xml:space="preserve">.. flat-table:: Physical Port Counter Table

https://netdev-3.bots.linux.dev/doc-build/results/32382/stderr

The indent is wrong?

* - xx
  - xx
  - xx

Vs yours:

* - xx
   - xx
   - xx

---
pw-bot: cr