linux-kernel - Re: [PATCH v3 0/2] (no cover subject)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <PN0PR01MB10393B82EB1038F184FD18894FED22@PN0PR01MB10393.INDPRD01.PROD.OUTLOOK.COM>
Date: Fri, 14 Mar 2025 08:11:34 +0800
From: Chen Wang <unicorn_wang@...look.com>
To: Zixian Zeng <sycamoremoon376@...il.com>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Paul Walmsley <paul.walmsley@...ive.com>,
 Palmer Dabbelt <palmer@...belt.com>, Albert Ou <aou@...s.berkeley.edu>,
 Inochi Amaoto <inochiama@...look.com>, Alexandre Ghiti <alex@...ti.fr>
Cc: devicetree@...r.kernel.org, linux-riscv@...ts.infradead.org,
 linux-kernel@...r.kernel.org, sophgo@...ts.linux.dev, chao.wei@...hgo.com,
 xiaoguang.xing@...hgo.com, dlan@...too.org
Subject: Re: [PATCH v3 0/2] (no cover subject)

Hi, Zixian,

First, it looks like you forgot to write a subject line for your email.

On 2025/3/13 21:11, Zixian Zeng wrote:
> This is tested on milkv-pioneer board. Using driver/spi/spidev.c
> for creating /dev/spidevX.Y and tools/spi/spidev_test for testing
> functionality.
Second, why is there no description of what was changed in the patch 
set? Maybe it was missed.

Introduction to testing can be used as supplementary information, but it 
should not be the main body of this email.

> Signed-off-by: Zixian Zeng <sycamoremoon376@...il.com>
> ---
> Changes in v3:
> - disable the spi status on sg2042-milkv-pioneer board
Not "disable", should be "Remove", and please capitalize the first 
letter of the sentences.
> - create dt-binding of compatible property
> - replace the general compatible property with SoC-specific in dts
Another relatively important change is about the clock, which you seem 
to have missed.
> - Link to v2: https://lore.kernel.org/r/20250228-sfg-spi-v2-1-8bbf23b85d0e@gmail.com
>
> Changes in v2:
> - rebase v1 to sophgo/master(github.com/sophgo/linux.git).
> - order properties in device node.
> - remove unevaluated properties `clock-frequency`.
> - set default status to disable.
> - Link to v1: https://lore.kernel.org/r/20250228-sfg-spi-v1-1-b989aed94911@gmail.com
>
> ---
> Zixian Zeng (2):
>        spi: dt-bindings: snps,dw-apb-ssi: Add compatible for SOPHGO SG2042 SoC
>        riscv: sophgo: dts: Add spi controller for SG2042
>
>   .../devicetree/bindings/spi/snps,dw-apb-ssi.yaml   |  4 ++++
>   arch/riscv/boot/dts/sophgo/sg2042.dtsi             | 26 ++++++++++++++++++++++
>   2 files changed, 30 insertions(+)
> ---
> base-commit: aa5ee7180ec41bb77c3e327e95d119f2294babea
> change-id: 20250228-sfg-spi-e3f2aeca09ab
>
> Best regards,

BTW, I suggest you wait until 6.15-rc1 comes out before submitting the 
next version, because I have already sent a PR to Arnd for Sophgo DTS.

Regards,

Chen