linux-kernel - Re: [PATCH v2 4/4] mm/mempolicy: Fix duplicate node addition in sysfs for weighted interleave

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250314063547.765-1-rakie.kim@sk.com>
Date: Fri, 14 Mar 2025 15:35:40 +0900
From: Rakie Kim <rakie.kim@...com>
To: Gregory Price <gourry@...rry.net>
Cc: akpm@...ux-foundation.org,
	linux-mm@...ck.org,
	linux-kernel@...r.kernel.org,
	linux-cxl@...r.kernel.org,
	joshua.hahnjy@...il.com,
	dan.j.williams@...el.com,
	ying.huang@...ux.alibaba.com,
	kernel_team@...ynix.com,
	honggyu.kim@...com,
	yunjeong.mun@...com,
	Rakie Kim <rakie.kim@...com>
Subject: Re: [PATCH v2 4/4] mm/mempolicy: Fix duplicate node addition in sysfs for weighted interleave

On Thu, 13 Mar 2025 12:42:03 -0400 Gregory Price <gourry@...rry.net> wrote:
> On Wed, Mar 12, 2025 at 04:56:27PM +0900, Rakie Kim wrote:
> > Sysfs attributes for interleave control were registered both at initialization
> > and when new nodes were detected via hotplug, leading to potential duplicates.
> > 
> > This patch ensures that each node is registered only once, preventing conflicts
> > and redundant sysfs entries.
> >
> 
> After looking more closely at patch 2, this seems to suggest we're not
> understanding the OFFLINE/ONLINE events well enough to use for this
> purpose.  I think this patch won't be needed once we address the
> concerns in patch 2 - and more generally if we discover it is needed
> this should just be rolled into patch 2 rather than kept separate.
> 
> ~Gregory

For this patch, it might be beneficial to merge it with another patch
or change its form. I will consider the changes, including the feedback
from Joshua.

Rakie