linux-kernel - Re: [PATCH] drm/ttm/tests: fix incorrect assert in ttm_bo_unreserve

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <738f554f-1ab3-4baa-84d1-91c76e508a53@amd.com>
Date: Fri, 14 Mar 2025 07:55:19 +0100
From: Christian König <christian.koenig@....com>
To: Qasim Ijaz <qasdev00@...il.com>, ray.huang@....com,
 maarten.lankhorst@...ux.intel.com, mripard@...nel.org, tzimmermann@...e.de,
 airlied@...il.com, simona@...ll.ch, thomas.hellstrom@...ux.intel.com,
 Arunpravin.PaneerSelvam@....com, karolina.stolarek@...el.com,
 jeff.johnson@....qualcomm.com, bigeasy@...utronix.de
Cc: dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/ttm/tests: fix incorrect assert in
 ttm_bo_unreserve_bulk()

Am 13.03.25 um 17:14 schrieb Qasim Ijaz:
> In the ttm_bo_unreserve_bulk() test function, resv is allocated using
> kunit_kzalloc(), but the subsequent assertion mistakenly verifies the
> ttm_dev pointer instead of the resv pointer.
>
> Fix the assertion to properly verify the resv pointer.
>
> Signed-off-by: Qasim Ijaz <qasdev00@...il.com>

Reviewed and pushed.

Thanks,
Christian.

> ---
>  drivers/gpu/drm/ttm/tests/ttm_bo_test.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/ttm/tests/ttm_bo_test.c b/drivers/gpu/drm/ttm/tests/ttm_bo_test.c
> index f8f20d2f6174..e08e5a138420 100644
> --- a/drivers/gpu/drm/ttm/tests/ttm_bo_test.c
> +++ b/drivers/gpu/drm/ttm/tests/ttm_bo_test.c
> @@ -340,7 +340,7 @@ static void ttm_bo_unreserve_bulk(struct kunit *test)
>  	KUNIT_ASSERT_NOT_NULL(test, ttm_dev);
>  
>  	resv = kunit_kzalloc(test, sizeof(*resv), GFP_KERNEL);
> -	KUNIT_ASSERT_NOT_NULL(test, ttm_dev);
> +	KUNIT_ASSERT_NOT_NULL(test, resv);
>  
>  	err = ttm_device_kunit_init(priv, ttm_dev, false, false);
>  	KUNIT_ASSERT_EQ(test, err, 0);