linux-kernel - Re: [PATCH 1/4] PCI: cadence: Add support to build pcie-cadence library as a kernel module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250314065444.fmvhyqmuefnm4mcq@uda0492258>
Date: Fri, 14 Mar 2025 12:24:44 +0530
From: Siddharth Vadapalli <s-vadapalli@...com>
To: Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
CC: Siddharth Vadapalli <s-vadapalli@...com>, <lpieralisi@...nel.org>,
        <kw@...ux.com>, <robh@...nel.org>, <bhelgaas@...gle.com>,
        <vigneshr@...com>, <kishon@...nel.org>, <cassel@...nel.org>,
        <wojciech.jasko-EXT@...tinental-corporation.com>,
        <thomas.richard@...tlin.com>, <bwawrzyn@...co.com>,
        <linux-pci@...r.kernel.org>, <linux-omap@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>,
        <srk@...com>
Subject: Re: [PATCH 1/4] PCI: cadence: Add support to build pcie-cadence
 library as a kernel module

On Thu, Mar 13, 2025 at 11:14:16PM +0530, Manivannan Sadhasivam wrote:

Hello Mani,

> On Fri, Mar 07, 2025 at 04:01:25PM +0530, Siddharth Vadapalli wrote:
> > From: Kishon Vijay Abraham I <kishon@...com>
> > 
> > Currently, the Cadence PCIe controller driver can be built as a built-in
> > module only. Since PCIe functionality is not a necessity for booting, add
> > support to build the Cadence PCIe driver as a loadable module as well.
> > 
> > Signed-off-by: Kishon Vijay Abraham I <kishon@...com>
> > Signed-off-by: Siddharth Vadapalli <s-vadapalli@...com>
> 
> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
> 
> > ---
> >  drivers/pci/controller/cadence/Kconfig             |  6 +++---
> >  drivers/pci/controller/cadence/pcie-cadence-ep.c   |  6 ++++++
> >  drivers/pci/controller/cadence/pcie-cadence-host.c |  9 +++++++++
> >  drivers/pci/controller/cadence/pcie-cadence.c      | 12 ++++++++++++
> >  drivers/pci/controller/cadence/pcie-cadence.h      |  4 ++--
> >  5 files changed, 32 insertions(+), 5 deletions(-)
> > 
> > diff --git a/drivers/pci/controller/cadence/Kconfig b/drivers/pci/controller/cadence/Kconfig
> > index 8a0044bb3989..82b58096eea0 100644
> > --- a/drivers/pci/controller/cadence/Kconfig
> > +++ b/drivers/pci/controller/cadence/Kconfig
> > @@ -4,16 +4,16 @@ menu "Cadence-based PCIe controllers"
> >  	depends on PCI
> >  
> >  config PCIE_CADENCE
> > -	bool
> > +	tristate
> >  
> >  config PCIE_CADENCE_HOST
> > -	bool
> > +	tristate
> >  	depends on OF
> >  	select IRQ_DOMAIN
> 
> Even though this was added earlier, looks like not needed.

Thank you for reviewing this patch.

drivers/pci/controller/cadence/Kconfig has the following:
...
	config PCIE_CADENCE_HOST
		bool
		depends on OF
		select IRQ_DOMAIN
		select PCIE_CADENCE
...
	config PCI_J721E_HOST
		bool "TI J721E PCIe controller (host mode)"
		depends on ARCH_K3 || COMPILE_TEST
		depends on OF
		select PCIE_CADENCE_HOST
		select PCI_J721E
...
So PCI_J721E_HOST selects PCIE_CADENCE_HOST which in turn selects
PCIE_CADENCE. As of now, none of these configs are enabled in
arm64-defconfig, and they also will not be accepted as built-in modules
as it will bloat the Linux Image for everyone. For that reason, they are
all being converted to loadable modules, and their configs will eventually
be enabled in arm64-defconfig as loadable modules.

Please let me know if I misunderstood your comment regarding the quoted
change not being required.

Regards,
Siddharth.