linux-kernel - Re: [PATCH v4 1/2] tracing: Fix a compilation error without CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250314054257.3218dc35@batman.local.home>
Date: Fri, 14 Mar 2025 05:42:57 -0400
From: Steven Rostedt <rostedt@...dmis.org>
To: "Masami Hiramatsu (Google)" <mhiramat@...nel.org>
Cc: Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
 linux-kernel@...r.kernel.org, linux-trace-kernel@...r.kernel.org
Subject: Re: [PATCH v4 1/2] tracing: Fix a compilation error without
 CONFIG_MODULES

On Fri, 14 Mar 2025 01:26:51 +0900
"Masami Hiramatsu (Google)" <mhiramat@...nel.org> wrote:

> @@ -6040,9 +6042,10 @@ static void update_last_data(struct trace_array *tr)
>  		memset(tscratch->entries, 0,
>  		       flex_array_size(tscratch, entries, tscratch->nr_entries));
>  		tscratch->nr_entries = 0;
> -
> +#ifdef CONFIG_MODULES
>  		guard(mutex)(&scratch_mutex);
>  		module_for_each_mod(save_mod, tr);
> +#endif
>  	}

Hmm, I think the real fix for this would be to make
module_for_each_mod() a nop when modules are not configured.

-- Steve