[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <20250318102552.7c7400873fa3f304cbefa9b6@kernel.org>
Date: Tue, 18 Mar 2025 10:25:52 +0900
From: Masami Hiramatsu (Google) <mhiramat@...nel.org>
To: Steven Rostedt <rostedt@...dmis.org>
Cc: Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
linux-kernel@...r.kernel.org, linux-trace-kernel@...r.kernel.org
Subject: Re: [PATCH v4 1/2] tracing: Fix a compilation error without
CONFIG_MODULES
On Fri, 14 Mar 2025 05:42:57 -0400
Steven Rostedt <rostedt@...dmis.org> wrote:
> On Fri, 14 Mar 2025 01:26:51 +0900
> "Masami Hiramatsu (Google)" <mhiramat@...nel.org> wrote:
>
> > @@ -6040,9 +6042,10 @@ static void update_last_data(struct trace_array *tr)
> > memset(tscratch->entries, 0,
> > flex_array_size(tscratch, entries, tscratch->nr_entries));
> > tscratch->nr_entries = 0;
> > -
> > +#ifdef CONFIG_MODULES
> > guard(mutex)(&scratch_mutex);
> > module_for_each_mod(save_mod, tr);
> > +#endif
> > }
>
> Hmm, I think the real fix for this would be to make
> module_for_each_mod() a nop when modules are not configured.
Yeah, but in this case, save_mod() need to be removed too[*]. Or is it
better to make save_mod() a nop too?
[*] https://lore.kernel.org/oe-kbuild-all/202503142045.0sE1neLa-lkp@intel.com/
Thank you,
>
> -- Steve
>
--
Masami Hiramatsu (Google) <mhiramat@...nel.org>
Powered by blists - more mailing lists