linux-kernel - Re: [PATCH] Fixed ideapad-laptop driver to support Yoga 9 2 in 1 14imh9 unknown keys

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f581c3d25a270801de35b7d0380cbd13c4c4a131.camel@irl.hu>
Date: Fri, 14 Mar 2025 12:52:39 +0100
From: Gergo Koteles <soyer@....hu>
To: Ike Panhc <ike.pan@...onical.com>,
  Gašper Nemgar <gasper.nemgar@...il.com>
Cc: linux-kernel@...r.kernel.org,
  "platform-driver-x86@...r.kernel.org" <platform-driver-x86@...r.kernel.org>
Subject: Re: [PATCH] Fixed ideapad-laptop driver to support Yoga 9 2 in 1
 14imh9 unknown keys

Hi Gašper,

On 3/13/25 23:17, Gašper Nemgar wrote:
>  	/* Specific to some newer models */
>  	{ KE_KEY,	0x3e | IDEAPAD_WMI_KEY, { KEY_MICMUTE } },
>  	{ KE_KEY,	0x3f | IDEAPAD_WMI_KEY, { KEY_RFKILL } },
> +	/*Star- (User Asignable Key)*/

Asignable -> Assignable?
Could you please add a space before/after the body of the comment?

> +	{ KE_KEY,	0x44 | IDEAPAD_WMI_KEY, { KEY_PROG1 } },

Other Ideapads map this star key to KEY_FAVORITES, for consistency I
think it would be better if this one mapped there too.

Thanks,
Gergo