linux-kernel - Re: [PATCH] Fixed ideapad-laptop driver to support Yoga 9 2 in 1 14imh9 unknown keys

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKi4K-j-j_SdKOAvxSWeQ9qPN-tMVicQ_nbKkNDvm8rEsY_N3g@mail.gmail.com>
Date: Fri, 14 Mar 2025 13:28:09 +0100
From: Gašper Nemgar <gasper.nemgar@...il.com>
To: Gergo Koteles <soyer@....hu>
Cc: Ike Panhc <ike.pan@...onical.com>, linux-kernel@...r.kernel.org, 
	"platform-driver-x86@...r.kernel.org" <platform-driver-x86@...r.kernel.org>
Subject: Re: [PATCH] Fixed ideapad-laptop driver to support Yoga 9 2 in 1
 14imh9 unknown keys

Hello,
This specific laptop has one star with s in the middle which is
already handled by the driver and is assigned to key favourites.
There is another button with only a star, I think it is ok to assign
it to KEY_PROG1.

Thanks, Gašper


On Fri, 14 Mar 2025 at 12:52, Gergo Koteles <soyer@....hu> wrote:
>
> Hi Gašper,
>
> On 3/13/25 23:17, Gašper Nemgar wrote:
> >       /* Specific to some newer models */
> >       { KE_KEY,       0x3e | IDEAPAD_WMI_KEY, { KEY_MICMUTE } },
> >       { KE_KEY,       0x3f | IDEAPAD_WMI_KEY, { KEY_RFKILL } },
> > +     /*Star- (User Asignable Key)*/
>
> Asignable -> Assignable?
> Could you please add a space before/after the body of the comment?
>
> > +     { KE_KEY,       0x44 | IDEAPAD_WMI_KEY, { KEY_PROG1 } },
>
> Other Ideapads map this star key to KEY_FAVORITES, for consistency I
> think it would be better if this one mapped there too.
>
> Thanks,
> Gergo
>
>