linux-kernel - Re: [PATCH v2 1/1] Input: snvs_pwrkey

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z9QuC7tZoXj3DRZs@9e5302bffcb7>
Date: Fri, 14 Mar 2025 15:24:27 +0200
From: Ian Ray <ian.ray@...ealthcare.com>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: dmitry.torokhov@...il.com, robh@...nel.org, krzk+dt@...nel.org,
	conor+dt@...nel.org, linux-input@...r.kernel.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/1] Input: snvs_pwrkey - support power-off-time-sec

On Fri, Mar 14, 2025 at 01:55:47PM +0100, Krzysztof Kozlowski wrote:
> On 14/03/2025 10:42, Ian Ray wrote:
> >
> >       /* Get SNVS register Page */
> > @@ -148,6 +152,24 @@ static int imx_snvs_pwrkey_probe(struct platform_device *pdev)
> >       if (pdata->irq < 0)
> >               return -EINVAL;
> >
> > +     if (!of_property_read_u32(np, "power-off-time-sec", &val)) {
> 
> And when you test your DTS against binding what do you see? I suspect
> new warning.

I checked the build logs (from a clean workarea), plus run-time dmesg,
both with the DTS change -- and without it.  There are no new warnings
(specifically nothing mentioning snvs-pwrkey or dts or power-off-time).

If an invalid value (such as "42") is chosen then the probe fails with
-EINVAL as expected.

Is there something else that I should have checked?

> 
> Best regards,
> Krzysztof

Blue skies,
Ian