| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20250315141249338P9_QqSBAnqEi-DZYDTtR5@zte.com.cn>
Date: Sat, 15 Mar 2025 14:12:49 +0800 (CST)
From: <xie.ludan@....com.cn>
To: <davem@...emloft.net>
Cc: <edumazet@...gle.com>, <kuba@...nel.org>, <pabeni@...hat.com>,
<horms@...nel.org>, <netdev@...r.kernel.org>,
<linux-kernel@...r.kernel.org>
Subject: [PATCH linux-next] net: atm: use sysfs_emit() instead of scnprintf().
From: XieLudan <xie.ludan@....com.cn>
Follow the advice in Documentation/filesystems/sysfs.rst:
show() should only use sysfs_emit() or sysfs_emit_at() when formatting
the value to be returned to user space.
Signed-off-by: XieLudan <xie.ludan@....com.cn>
---
net/atm/atm_sysfs.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/net/atm/atm_sysfs.c b/net/atm/atm_sysfs.c
index 54e7fb1a4ee5..0aab1c3c05de 100644
--- a/net/atm/atm_sysfs.c
+++ b/net/atm/atm_sysfs.c
@@ -16,7 +16,7 @@ static ssize_t type_show(struct device *cdev,
{
struct atm_dev *adev = to_atm_dev(cdev);
- return scnprintf(buf, PAGE_SIZE, "%s\n", adev->type);
+ return sysfs_emit(buf, "%s\n", adev->type);
}
static ssize_t address_show(struct device *cdev,
@@ -24,7 +24,7 @@ static ssize_t address_show(struct device *cdev,
{
struct atm_dev *adev = to_atm_dev(cdev);
- return scnprintf(buf, PAGE_SIZE, "%pM\n", adev->esi);
+ return sysfs_emit(buf, "%pM\n", adev->esi);
}
static ssize_t atmaddress_show(struct device *cdev,
@@ -37,7 +37,7 @@ static ssize_t atmaddress_show(struct device *cdev,
spin_lock_irqsave(&adev->lock, flags);
list_for_each_entry(aaddr, &adev->local, entry) {
- count += scnprintf(buf + count, PAGE_SIZE - count,
+ count += sysfs_emit(buf + count,
"%1phN.%2phN.%10phN.%6phN.%1phN\n",
&aaddr->addr.sas_addr.prv[0],
&aaddr->addr.sas_addr.prv[1],
@@ -55,7 +55,7 @@ static ssize_t atmindex_show(struct device *cdev,
{
struct atm_dev *adev = to_atm_dev(cdev);
- return scnprintf(buf, PAGE_SIZE, "%d\n", adev->number);
+ return sysfs_emit(buf, "%d\n", adev->number);
}
static ssize_t carrier_show(struct device *cdev,
@@ -63,7 +63,7 @@ static ssize_t carrier_show(struct device *cdev,
{
struct atm_dev *adev = to_atm_dev(cdev);
- return scnprintf(buf, PAGE_SIZE, "%d\n",
+ return sysfs_emit(buf, "%d\n",
adev->signal == ATM_PHY_SIG_LOST ? 0 : 1);
}
@@ -87,7 +87,7 @@ static ssize_t link_rate_show(struct device *cdev,
default:
link_rate = adev->link_rate * 8 * 53;
}
- return scnprintf(buf, PAGE_SIZE, "%d\n", link_rate);
+ return sysfs_emit(buf, "%d\n", link_rate);
}
static DEVICE_ATTR_RO(address);
--
2.25.1
<div class="zcontentRow"><p><span style="font-family: Arial, Helvetica, "Microsoft Yahei", sans-serif; background-color: rgb(255, 255, 255);">From: XieLudan <xie.ludan@....com.cn></span></p><p><br></p><p>Follow the advice in Documentation/filesystems/sysfs.rst:</p><p>show() should only use sysfs_emit() or sysfs_emit_at() when formatting</p><p>the value to be returned to user space.</p><p><br></p><p>Signed-off-by: XieLudan <xie.ludan@....com.cn></p><p>---</p><p> net/atm/atm_sysfs.c | 12 ++++++------</p><p> 1 file changed, 6 insertions(+), 6 deletions(-)</p><p><br></p><p>diff --git a/net/atm/atm_sysfs.c b/net/atm/atm_sysfs.c</p><p>index 54e7fb1a4ee5..0aab1c3c05de 100644</p><p>--- a/net/atm/atm_sysfs.c</p><p>+++ b/net/atm/atm_sysfs.c</p><p>@@ -16,7 +16,7 @@ static ssize_t type_show(struct device *cdev,</p><p> {</p><p> <span style="white-space:pre"> </span>struct atm_dev *adev = to_atm_dev(cdev);</p><p> </p><p>-<span style="white-space:pre"> </span>return scnprintf(buf, PAGE_SIZE, "%s\n", adev->type);</p><p>+<span style="white-space:pre"> </span>return sysfs_emit(buf, "%s\n", adev->type);</p><p> }</p><p> </p><p> static ssize_t address_show(struct device *cdev,</p><p>@@ -24,7 +24,7 @@ static ssize_t address_show(struct device *cdev,</p><p> {</p><p> <span style="white-space:pre"> </span>struct atm_dev *adev = to_atm_dev(cdev);</p><p> </p><p>-<span style="white-space:pre"> </span>return scnprintf(buf, PAGE_SIZE, "%pM\n", adev->esi);</p><p>+<span style="white-space:pre"> </span>return sysfs_emit(buf, "%pM\n", adev->esi);</p><p> }</p><p> </p><p> static ssize_t atmaddress_show(struct device *cdev,</p><p>@@ -37,7 +37,7 @@ static ssize_t atmaddress_show(struct device *cdev,</p><p> </p><p> <span style="white-space:pre"> </span>spin_lock_irqsave(&adev->lock, flags);</p><p> <span style="white-space:pre"> </span>list_for_each_entry(aaddr, &adev->local, entry) {</p><p>-<span style="white-space:pre"> </span>count += scnprintf(buf + count, PAGE_SIZE - count,</p><p>+<span style="white-space:pre"> </span>count += sysfs_emit(buf + count,</p><p> <span style="white-space:pre"> </span> "%1phN.%2phN.%10phN.%6phN.%1phN\n",</p><p> <span style="white-space:pre"> </span> &aaddr->addr.sas_addr.prv[0],</p><p> <span style="white-space:pre"> </span> &aaddr->addr.sas_addr.prv[1],</p><p>@@ -55,7 +55,7 @@ static ssize_t atmindex_show(struct device *cdev,</p><p> {</p><p> <span style="white-space:pre"> </span>struct atm_dev *adev = to_atm_dev(cdev);</p><p> </p><p>-<span style="white-space:pre"> </span>return scnprintf(buf, PAGE_SIZE, "%d\n", adev->number);</p><p>+<span style="white-space:pre"> </span>return sysfs_emit(buf, "%d\n", adev->number);</p><p> }</p><p> </p><p> static ssize_t carrier_show(struct device *cdev,</p><p>@@ -63,7 +63,7 @@ static ssize_t carrier_show(struct device *cdev,</p><p> {</p><p> <span style="white-space:pre"> </span>struct atm_dev *adev = to_atm_dev(cdev);</p><p> </p><p>-<span style="white-space:pre"> </span>return scnprintf(buf, PAGE_SIZE, "%d\n",</p><p>+<span style="white-space:pre"> </span>return sysfs_emit(buf, "%d\n",</p><p> <span style="white-space:pre"> </span> adev->signal == ATM_PHY_SIG_LOST ? 0 : 1);</p><p> }</p><p> </p><p>@@ -87,7 +87,7 @@ static ssize_t link_rate_show(struct device *cdev,</p><p> <span style="white-space:pre"> </span>default:</p><p> <span style="white-space:pre"> </span>link_rate = adev->link_rate * 8 * 53;</p><p> <span style="white-space:pre"> </span>}</p><p>-<span style="white-space:pre"> </span>return scnprintf(buf, PAGE_SIZE, "%d\n", link_rate);</p><p>+<span style="white-space:pre"> </span>return sysfs_emit(buf, "%d\n", link_rate);</p><p> }</p><p> </p><p> static DEVICE_ATTR_RO(address);</p><p>-- </p><p>2.25.1</p><p style="font-size:14px;font-family:微软雅黑,Microsoft YaHei;"><br></p><p style="font-size:14px;font-family:微软雅黑,Microsoft YaHei;"><br></p><p style="font-size:14px;font-family:微软雅黑,Microsoft YaHei;"><br></p><p style="font-size:14px;font-family:微软雅黑,Microsoft YaHei;"><br></p></div>
Powered by blists - more mailing lists