linux-kernel - Re: [PATCH linux-next] net: atm: use sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <18022b24-1480-4062-9c18-193729efacef@kernel.org>
Date: Mon, 17 Mar 2025 07:22:34 +0100
From: Jiri Slaby <jirislaby@...nel.org>
To: xie.ludan@....com.cn, davem@...emloft.net
Cc: edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
 horms@...nel.org, netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH linux-next] net: atm: use sysfs_emit() instead of
 scnprintf().

On 15. 03. 25, 7:12, xie.ludan@....com.cn wrote:
> @@ -37,7 +37,7 @@ static ssize_t atmaddress_show(struct device *cdev,
> 
> spin_lock_irqsave(&adev->lock, flags);
> 
> list_for_each_entry(aaddr, &adev->local, entry) {
> 
> -count += scnprintf(buf + count, PAGE_SIZE - count,
> 
> +count += sysfs_emit(buf + count,

This is wrong too [1].

[1] 
https://lore.kernel.org/all/9c552d9a-2d46-4069-a9c4-35fab857bfc3@kernel.org/

regards,

-- 
js
suse labs