lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Z9gr11GUYPWxPMSc@bogus>
Date: Mon, 17 Mar 2025 14:04:07 +0000
From: Sudeep Holla <sudeep.holla@....com>
To: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc: linux-kernel@...r.kernel.org, Ard Biesheuvel <ardb@...nel.org>,
	Alexandre Belloni <alexandre.belloni@...tlin.com>,
	Sudeep Holla <sudeep.holla@....com>, linux-rtc@...r.kernel.org,
	linux-efi@...r.kernel.org
Subject: Re: [PATCH 4/9] rtc: efi: Transition to the faux device interface

On Mon, Mar 17, 2025 at 02:07:00PM +0100, Greg Kroah-Hartman wrote:
> On Mon, Mar 17, 2025 at 10:13:16AM +0000, Sudeep Holla wrote:
> > The EFI RTC driver does not require the creation of a platform device.
> > Originally, this approach was chosen for simplicity when the driver was
> > first implemented.
> > 
> > With the introduction of the lightweight faux device interface, we now
> > have a more appropriate alternative. Migrate the driver to utilize the
> > faux bus, given that the platform device it previously created was not
> > a real one anyway. This will simplify the code, reducing its footprint
> > while maintaining functionality.
> > 
> > Cc: Ard Biesheuvel <ardb@...nel.org>
> > Cc: Alexandre Belloni <alexandre.belloni@...tlin.com>
> > Cc: linux-rtc@...r.kernel.org
> > Cc: linux-efi@...r.kernel.org
> > Signed-off-by: Sudeep Holla <sudeep.holla@....com>
> > ---
> >  drivers/firmware/efi/efi.c |  3 ---
> >  drivers/rtc/rtc-efi.c      | 31 ++++++++++++++++++++++---------
> >  2 files changed, 22 insertions(+), 12 deletions(-)
> > 

[...]

> > -MODULE_ALIAS("platform:rtc-efi");
> > +MODULE_ALIAS("faux:rtc-efi");
> 
> No alias please.

Thanks for the review, will drop all the alias.

-- 
Regards,
Sudeep

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ