linux-kernel - Re: [PATCH 7/9] net: phy: fixed_phy: transition to the faux device interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z9gu86r9pdFPGxrb@bogus>
Date: Mon, 17 Mar 2025 14:17:23 +0000
From: Sudeep Holla <sudeep.holla@....com>
To: Andrew Lunn <andrew@...n.ch>
Cc: linux-kernel@...r.kernel.org, Sudeep Holla <sudeep.holla@....com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	"David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: [PATCH 7/9] net: phy: fixed_phy: transition to the faux device
 interface

On Mon, Mar 17, 2025 at 01:29:31PM +0100, Andrew Lunn wrote:
> On Mon, Mar 17, 2025 at 10:13:19AM +0000, Sudeep Holla wrote:
> > The net fixed phy driver does not require the creation of a platform
> > device. Originally, this approach was chosen for simplicity when the
> > driver was first implemented.
> > 
> > With the introduction of the lightweight faux device interface, we now
> > have a more appropriate alternative. Migrate the driver to utilize the
> > faux bus, given that the platform device it previously created was not
> > a real one anyway. This will simplify the code, reducing its footprint
> > while maintaining functionality.
> > 
> > Cc: Andrew Lunn <andrew@...n.ch>
> > Cc: "David S. Miller" <davem@...emloft.net>
> > Cc: netdev@...r.kernel.org
> > Signed-off-by: Sudeep Holla <sudeep.holla@....com>
> > ---
> >  drivers/net/phy/fixed_phy.c | 16 ++++++++--------
> >  1 file changed, 8 insertions(+), 8 deletions(-)
> 
> 8 insertions, 8 deletions. How does this reduce its footprint?
>

I meant the use of struct faux_device vs struct platform_device. Yes
it is not a big deal.

> Seems like pointless churn to me. Unless there is a real advantage to
> faux bus you are not enumerating in your commit message.
> 

Greg has answered that, so will skip.

-- 
Regards,
Sudeep