linux-kernel - Re: [PATCH v5] ARM: dts: nexus4: Initial dts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7z2u2almxk7rnd6cx6nq3ypgbzvttkj3jqawv5jojayjz3foix@zprthr6awbcp>
Date: Mon, 17 Mar 2025 17:13:01 +0200
From: Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>
To: "Rob Herring (Arm)" <robh@...nel.org>
Cc: David Heidelberg <david@...t.cz>, devicetree@...r.kernel.org,
        Bjorn Andersson <andersson@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Konrad Dybcio <konradybcio@...nel.org>,
        Ivan Belokobylskiy <belokobylskij@...il.com>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Tony Luck <tony.luck@...el.com>, linux-hardening@...r.kernel.org,
        Kees Cook <kees@...nel.org>, linux-kernel@...r.kernel.org,
        linux-arm-msm@...r.kernel.org,
        "Guilherme G. Piccoli" <gpiccoli@...lia.com>
Subject: Re: [PATCH v5] ARM: dts: nexus4: Initial dts

On Mon, Mar 17, 2025 at 09:18:33AM -0500, Rob Herring (Arm) wrote:
> 
> On Sun, 16 Mar 2025 23:16:55 +0100, David Heidelberg wrote:
> > From: Ivan Belokobylskiy <belokobylskij@...il.com>
> > 
> > Add initial support for LG Nexus 4 (mako).
> > 
> > Features currently working: regulators, eMMC, and volume keys.
> > 
> > Signed-off-by: Ivan Belokobylskiy <belokobylskij@...il.com>
> > Co-developed-by: David Heidelberg <david@...t.cz>
> > Signed-off-by: David Heidelberg <david@...t.cz>
> > ---
> > Changes in v5:
> > - Sorted nodes alphabetically.
> > - Link to v4: https://lore.kernel.org/r/20250311-lg-nexus4-mako-v4-1-3916c8ec7edb@ixit.cz
> > 
> > Changes in v4:
> > - Sorted regulators and added regulators compatible.
> > - Corrected pmic include and references.
> > - Moved &rpm outside of / node.
> > - Moved and simplify pm8921 keypad.
> > - Added chasis-type.
> > - Dropped incomplete WiFi node, will be provided in future
> >   contributions.
> > - Link to v3: https://lore.kernel.org/r/20250309-lg-nexus4-mako-v3-1-1dc2807df296@ixit.cz
> > 
> > Changes in v3:
> > - rebased against next-20250307
> > - dropped backlight until driver gets converted to DT
> > 
> > Changes in v2:
> > - lge vendor doesn't exist anymore, rename to lg
> > - sdcc@ to mmc@ to comply with dt-schema
> > ---
> >  arch/arm/boot/dts/qcom/Makefile                    |   1 +
> >  .../boot/dts/qcom/qcom-apq8064-lg-nexus4-mako.dts  | 341 +++++++++++++++++++++
> >  2 files changed, 342 insertions(+)
> > 
> 
> 
> My bot found new DTB warnings on the .dts files added or changed in this
> series.
> 
> Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
> are fixed by another series. Ultimately, it is up to the platform
> maintainer whether these warnings are acceptable or not. No need to reply
> unless the platform maintainer has comments.
> 
> If you already ran DT checks and didn't see these error(s), then
> make sure dt-schema is up to date:
> 
>   pip3 install dtschema --upgrade
> 
> 
> New warnings running 'make CHECK_DTBS=y for arch/arm/boot/dts/qcom/' for 20250316-lg-nexus4-mako-v5-1-79feae815a85@...t.cz:
> 
> arch/arm/boot/dts/qcom/qcom-apq8064-lg-nexus4-mako.dtb: hwmutex: 'reg' is a required property
> 	from schema $id: http://devicetree.org/schemas/hwlock/qcom-hwspinlock.yaml#
> arch/arm/boot/dts/qcom/qcom-apq8064-lg-nexus4-mako.dtb: hwmutex: 'syscon' does not match any of the regexes: 'pinctrl-[0-9]+'
> 	from schema $id: http://devicetree.org/schemas/hwlock/qcom-hwspinlock.yaml#
> arch/arm/boot/dts/qcom/qcom-apq8064-lg-nexus4-mako.dtb: soc: replicator: 'ranges' is a required property
> 	from schema $id: http://devicetree.org/schemas/simple-bus.yaml#
> arch/arm/boot/dts/qcom/qcom-apq8064-lg-nexus4-mako.dtb: syscon@...0000: compatible: ['syscon'] is too short
> 	from schema $id: http://devicetree.org/schemas/mfd/syscon-common.yaml#
> arch/arm/boot/dts/qcom/qcom-apq8064-lg-nexus4-mako.dtb: timer@...a000: 'clocks' is a required property
> 	from schema $id: http://devicetree.org/schemas/watchdog/qcom-wdt.yaml#
> arch/arm/boot/dts/qcom/qcom-apq8064-lg-nexus4-mako.dtb: sps-sic-non-secure@...00000: compatible: ['syscon'] is too short
> 	from schema $id: http://devicetree.org/schemas/mfd/syscon-common.yaml#
> arch/arm/boot/dts/qcom/qcom-apq8064-lg-nexus4-mako.dtb: rpm@...000: 'clock-controller' does not match any of the regexes: '^regulators(-[01])?$', 'pinctrl-[0-9]+'
> 	from schema $id: http://devicetree.org/schemas/soc/qcom/qcom,rpm.yaml#
> arch/arm/boot/dts/qcom/qcom-apq8064-lg-nexus4-mako.dtb: syscon@...0000: compatible: ['syscon'] is too short
> 	from schema $id: http://devicetree.org/schemas/mfd/syscon-common.yaml#
> arch/arm/boot/dts/qcom/qcom-apq8064-lg-nexus4-mako.dtb: replicator: 'clock-names', 'clocks' do not match any of the regexes: 'pinctrl-[0-9]+'
> 	from schema $id: http://devicetree.org/schemas/arm/arm,coresight-static-replicator.yaml#

As far as I can see, all those are generic rather than being introduced
by the new DT. I'll send a set of fixes soon.

-- 
With best wishes
Dmitry