linux-kernel - Re: [PATCH v3 1/6] soc: renesas: rz-sysc: add syscon/regmap support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMuHMdXWGLUzJFKdDR3hLf0iOoKzb15fNQmvzZZQq-a8e6cxfQ@mail.gmail.com>
Date: Mon, 17 Mar 2025 16:12:54 +0100
From: Geert Uytterhoeven <geert@...ux-m68k.org>
To: John Madieu <john.madieu.xa@...renesas.com>
Cc: conor+dt@...nel.org, krzk+dt@...nel.org, robh@...nel.org, 
	rafael@...nel.org, daniel.lezcano@...aro.org, magnus.damm@...il.com, 
	devicetree@...r.kernel.org, john.madieu@...il.com, rui.zhang@...el.com, 
	linux-kernel@...r.kernel.org, linux-renesas-soc@...r.kernel.org, 
	sboyd@...nel.org, biju.das.jz@...renesas.com, linux-pm@...r.kernel.org, 
	lukasz.luba@....com
Subject: Re: [PATCH v3 1/6] soc: renesas: rz-sysc: add syscon/regmap support

On Sat, 15 Mar 2025 at 09:12, John Madieu <john.madieu.xa@...renesas.com> wrote:
> The RZ/G3E system controller has various registers that control or report
> some properties specific to individual IPs. The regmap is registered as a
> syscon device to allow these IP drivers to access the registers through the
> regmap API.
>
> As other RZ SoCs might have custom read/write callbacks or max-offsets, let's
> register a custom regmap configuration.
>
> Signed-off-by: John Madieu <john.madieu.xa@...renesas.com>

> --- a/drivers/soc/renesas/rz-sysc.c
> +++ b/drivers/soc/renesas/rz-sysc.c
> @@ -6,8 +6,10 @@
>   */
>
>  #include <linux/io.h>
> +#include <linux/mfd/syscon.h>
>  #include <linux/of.h>
>  #include <linux/platform_device.h>
> +#include <linux/regmap.h>
>  #include <linux/sys_soc.h>
>
>  #include "rz-sysc.h"
> @@ -81,6 +83,14 @@ static int rz_sysc_soc_init(struct rz_sysc *sysc, const struct of_device_id *mat
>         return 0;
>  }
>
> +static struct regmap_config rz_sysc_regmap = {

WARNING: struct regmap_config should normally be const

Aborting review, new version has been posted...

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds