Message-ID: <20250317125553028rN6mepsLlgyvSWxALaCDB@zte.com.cn>
Date: Mon, 17 Mar 2025 12:55:53 +0800 (CST)
From: <feng.wei8@....com.cn>
To: <johannes@...solutions.net>
Cc: <linux-kernel@...r.kernel.org>, <linux-wireless@...r.kernel.org>
Subject: Re: [PATCH] mac80211: minstrel_ht: Replace nested min() with single   min3()

I see the following commit：
|https://web.git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=ab936836ec09fa23954e8e5785d71a41e5ee8bcb 

I don't think code optimization and unification is "garbage". If so, why did you choose to merge into a commit like "garbage".
I'm just bothered by this aspect when I usually look at the code, so why not be concise.
I would even like to implement `min4/max4` like `dml_min4/dml_max4`. Wouldn't that be more concise code?

As a newcomer, my perspectives may differ from those of the experts here. I apologize if this has caused any inconvenience.
Thanks



Original


From: johannes <johannes@...solutions.net>
To: Feng Wei10332721;linux-kernel <linux-kernel@...r.kernel.org>;
Cc: linux-wireless <linux-wireless@...r.kernel.org>;
Date: 2025/03/16 22:01
Subject: Re: [PATCH] mac80211: minstrel_ht: Replace nested min() with single min3()

Please do not send utter garbage patches. It wastes everyone's time.
 
If you don't know what you're doing, just stop. There's very very little
value in such patches anyway, so don't send them. First think if it
actually does something useful, and if in doubt, don't.
 
johannes
<div class="zcontentRow"><p style="font-size:14px;font-family:微软雅黑,Microsoft YaHei;">I see the following commit：</p><p style="font-size:14px;font-family:微软雅黑,Microsoft YaHei;">|<a href="https://web.git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=ab936836ec09fa23954e8e5785d71a41e5ee8bcb"></a><a href="https://web.git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=ab936836ec09fa23954e8e5785d71a41e5ee8bcb">https://web.git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=ab936836ec09fa23954e8e5785d71a41e5ee8bcb</a> </p>I don't think code optimization and unification is "garbage". If so, why did you choose to merge into a commit like "garbage".<br>I'm just bothered by this aspect when I usually look at the code, so why not be concise.<br>I would even like to implement `min4/max4` like `dml_min4/dml_max4`. Wouldn't that be more concise code?<p style="font-size:14px;font-family:微软雅黑,Microsoft YaHei;"><br></p><p style="font-size:14px;font-family:微软雅黑,Microsoft YaHei;"><span style="color: rgb(51, 51, 51); font-family: &quot;PingFang SC&quot;, Arial, Helvetica, sans-serif; font-size: 16px; background-color: rgb(255, 255, 255);">As a newcomer, my perspectives may differ from those of the experts here. I apologize if this has caused any inconvenience.</span></p><p style="font-size:14px;font-family:微软雅黑,Microsoft YaHei;"><span style="color: rgb(51, 51, 51); font-family: &quot;PingFang SC&quot;, Arial, Helvetica, sans-serif; font-size: 16px; background-color: rgb(255, 255, 255);">Thanks</span></p><p style="font-size:14px;font-family:微软雅黑,Microsoft YaHei;"><br></p><p style="font-size:14px;font-family:微软雅黑,Microsoft YaHei;"><br></p><div class="zhistoryRow" style="display:block"><div class="zhistoryDes" style="width: 100%; height: 28px; line-height: 28px; background-color: #E0E5E9; color: #1388FF; text-align: center;">Original</div><div id="zwriteHistoryContainer"><div class="control-group zhistoryPanel"><div class="zhistoryHeader" style="padding: 8px; background-color: #F5F6F8;"><div><strong>From:&nbsp;</strong><span class="zreadUserName">johannes &lt;johannes@...solutions.net&gt;</span></div><div><strong>To:&nbsp;</strong><span class="zreadUserName" style="display: inline;">Feng Wei10332721;</span><span class="zreadUserName" style="display: inline;">linux-kernel &lt;linux-kernel@...r.kernel.org&gt;;</span></div><div><strong>Cc:&nbsp;</strong><span class="zreadUserName" style="display: inline;">linux-wireless &lt;linux-wireless@...r.kernel.org&gt;;</span></div><div><strong>Date:&nbsp;</strong><span class="">2025/03/16 22:01</span></div><div><strong>Subject:&nbsp;</strong><span class="zreadTitle"><strong>Re: [PATCH] mac80211: minstrel_ht: Replace nested min() with single   min3()</strong></span></div></div><div class="zhistoryContent">Please&nbsp;do&nbsp;not&nbsp;send&nbsp;utter&nbsp;garbage&nbsp;patches.&nbsp;It&nbsp;wastes&nbsp;everyone's&nbsp;time.<br> <br>If&nbsp;you&nbsp;don't&nbsp;know&nbsp;what&nbsp;you're&nbsp;doing,&nbsp;just&nbsp;stop.&nbsp;There's&nbsp;very&nbsp;very&nbsp;little<br>value&nbsp;in&nbsp;such&nbsp;patches&nbsp;anyway,&nbsp;so&nbsp;don't&nbsp;send&nbsp;them.&nbsp;First&nbsp;think&nbsp;if&nbsp;it<br>actually&nbsp;does&nbsp;something&nbsp;useful,&nbsp;and&nbsp;if&nbsp;in&nbsp;doubt,&nbsp;don't.<br> <br>johannes</div></div></div></div><p><br></p></div>

Powered by blists - more mailing lists