linux-kernel - Re: [PATCH] mac80211: minstrel_ht: Replace nested min() with single min3()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <24629d2d-0432-4811-9eee-634e3fe55419@kernel.org>
Date: Mon, 17 Mar 2025 09:27:38 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: feng.wei8@....com.cn, johannes@...solutions.net, xie.ludan@....com.cn,
 shao.mingyin@....com.cn, xie.ludan@....com.cn, tang.dongxing@....com.cn,
 davem@...emloft.net, feng.wei8@....com.cn
Cc: linux-kernel@...r.kernel.org, linux-wireless@...r.kernel.org
Subject: Re: [PATCH] mac80211: minstrel_ht: Replace nested min() with single
 min3()

On 17/03/2025 05:55, feng.wei8@....com.cn wrote:
> I see the following commit：
> |https://web.git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=ab936836ec09fa23954e8e5785d71a41e5ee8bcb 

I do not see Johannes merged that. Do you understand how Git and kernel
process work?

> 
> I don't think code optimization and unification is "garbage". If so, why did you choose to merge into a commit like "garbage".
> I'm just bothered by this aspect when I usually look at the code, so why not be concise.

No, you just run some static tools, coccinelle or whatever else and
flood us with patches all over the tree, claiming that they improve
anything.

Nothing here was done in terms of choice of improvement but it's pure
automation.

In many places it was already pointed out that your automation is not
even correct.

> I would even like to implement `min4/max4` like `dml_min4/dml_max4`. Wouldn't that be more concise code?
> 
> As a newcomer, my perspectives may differ from those of the experts here. I apologize if this has caused any inconvenience.


Best regards,
Krzysztof