linux-kernel - Re: [PATCH] mac80211: minstrel_ht: Replace nested min() with single min3()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f6dfffc0-a9bd-4a5f-9d83-f3a4b7918010@kernel.org>
Date: Mon, 17 Mar 2025 09:30:30 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: feng.wei8@....com.cn, linux-kernel@...r.kernel.org,
 tang.dongxing@....com.cn, feng.wei8@....com.cn, shao.mingyin@....com.cn,
 xie.ludan@....com.cn, yang.guang5@....com.cn, yang.yang29@....com.cn,
 ye.xingchen@....com.cn, xu.xin16@....com.cn
Cc: johannes@...solutions.net, linux-wireless@...r.kernel.org
Subject: Re: [PATCH] mac80211: minstrel_ht: Replace nested min() with single
 min3()

On 15/03/2025 04:12, feng.wei8@....com.cn wrote:
> From: FengWei <feng.wei8@....com.cn>
> 
> Use min3() macro instead of nesting min() to simplify the return
> statement.
> 
> Signed-off-by: FengWei <feng.wei8@....com.cn>
> ---
>  net/mac80211/rc80211_minstrel_ht.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/mac80211/rc80211_minstrel_ht.c b/net/mac80211/rc80211_minstrel_ht.c
> index 08f3f530f984..31a3b6e4c58d 100644
> --- a/net/mac80211/rc80211_minstrel_ht.c
> +++ b/net/mac80211/rc80211_minstrel_ht.c
> @@ -1010,7 +1010,7 @@ minstrel_ht_refill_sample_rates(struct minstrel_ht_sta *mi)
>  	u32 prob_dur = minstrel_get_duration(mi->max_prob_rate);
>  	u32 tp_dur = minstrel_get_duration(mi->max_tp_rate[0]);
>  	u32 tp2_dur = minstrel_get_duration(mi->max_tp_rate[1]);
> -	u32 fast_rate_dur = min(tp_dur, tp2_dur, prob_dur);
> +	u32 fast_rate_dur = min3(tp_dur, tp2_dur, prob_dur);

This is automation-generated junk code. How does it "simplify the
statement"?

Can ZTE slow down this flood of automation or research experiment on
kernel community?

Best regards,
Krzysztof