linux-kernel - Re: [PATCH] mac80211: minstrel_ht: Replace nested min() with single min3()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8c02c4f7452f2fbb41c8bc0517af9588c25ca7b1.camel@sipsolutions.net>
Date: Mon, 17 Mar 2025 09:31:38 +0100
From: Johannes Berg <johannes@...solutions.net>
To: Krzysztof Kozlowski <krzk@...nel.org>, feng.wei8@....com.cn, 
	linux-kernel@...r.kernel.org, tang.dongxing@....com.cn,
 shao.mingyin@....com.cn, 	xie.ludan@....com.cn, yang.guang5@....com.cn,
 yang.yang29@....com.cn, 	ye.xingchen@....com.cn, xu.xin16@....com.cn
Cc: linux-wireless@...r.kernel.org
Subject: Re: [PATCH] mac80211: minstrel_ht: Replace nested min() with single
 min3()

On Mon, 2025-03-17 at 09:30 +0100, Krzysztof Kozlowski wrote:
> 
> > +++ b/net/mac80211/rc80211_minstrel_ht.c
> > @@ -1010,7 +1010,7 @@ minstrel_ht_refill_sample_rates(struct minstrel_ht_sta *mi)
> >  	u32 prob_dur = minstrel_get_duration(mi->max_prob_rate);
> >  	u32 tp_dur = minstrel_get_duration(mi->max_tp_rate[0]);
> >  	u32 tp2_dur = minstrel_get_duration(mi->max_tp_rate[1]);
> > -	u32 fast_rate_dur = min(tp_dur, tp2_dur, prob_dur);
> > +	u32 fast_rate_dur = min3(tp_dur, tp2_dur, prob_dur);
> 
> This is automation-generated junk code. How does it "simplify the
> statement"?

It's worse. The "minus" code doesn't even exist upstream.

> Can ZTE slow down this flood of automation or research experiment on
> kernel community?

Please.

johannes