linux-kernel - Re: [PATCH v2 2/2] Input: atkbd - Correctly map F13

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f742f82e-d533-431f-bf64-01cec4bead09@tuxedocomputers.com>
Date: Mon, 17 Mar 2025 17:47:34 +0100
From: Werner Sembach <wse@...edocomputers.com>
To: Hans de Goede <hdegoede@...hat.com>,
 Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc: linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/2] Input: atkbd - Correctly map F13 - F24

Hi again,

Am 17.03.25 um 13:06 schrieb Hans de Goede:
> Hi,
>
> On 11-Mar-25 19:10, Werner Sembach wrote:
>> Hi Hans, Hi Dimitry,
>>
>> resending this too on the v2 to not cause confusion:
>>
>> Regarding remapping KEY_ZENKAKUHANKAKU to KEY_TOUCHPAD_TOGGLE:
>>
>> Am 11.03.25 um 19:06 schrieb Werner Sembach:
>>> Currently only F23 is correctly mapped for PS/2 keyboards.
>>>
>>> Following to this table:
>>> https://download.microsoft.com/download/1/6/1/161ba512-40e2-4cc9-843a-923143f3456c/translate.pdf
>>>
>>> - F24 and Zenkaku/Hankaku share the same scancode, but since in real world
>>> Zenkaku/Hankaku keys seem to just use the tilde scancode, this patch binds the
>>> scancode to F24. Note that on userspace side the KEY_ZENKAKUHANKAKU keycode is
>>> currently not bound in xkeyboard-config, so it is (mostly*) unused anyway.
>> I think what the firmware vendor actually wanted to do was to send ctrl+super+f24 upon touchpad toggle. This would somewhat fall in line with, for example, the copilot key being implemented as shift+super+f23.
> I agree that that seems to be the intent.
>
>> Following this, my suggestion is to do this remapping and handle the rest in xkeyboard-config
> xkeyboard config already contains mappings for F13 - F18 and F20-F23 in
> /usr/share/X11/xkb/symbols/inet
>
> So all that needs to happen there is map FK19 -> F19 and FK24 -> F24.
>
> And then teach KDE + GNOME that ctrl+super+f24 means touchpad-toggle.

Alternative suggestion, again following how the copilot key is implemented:

key <FK19>   {      [ F19 ]       };
[...]
key <FK23>   {      [ XF86TouchpadOff, XF86Assistant ], type[Group1] = 
"PC_SHIFT_SUPER_LEVEL2" };
key <FK24>   {      [ F24, XF86TouchpadToggle ], type[Group1] = 
"PC_CONTROL_SUPER_LEVEL2" };

Then only xkb has to be touched again, but not KDE and GNOME.

>
> We could maybe get away with also dropping the weird mappings for FK13 - FK18
> and map those straight to F13 - F18, but we need the special mappings
> for F20 - F23 to stay in place to not break stuff.

Good question

XF86Tools launches system settings on KDE.

XF86Launch5-9 do nothing by default afaict.

Looking at the links in the git log of xkeyboard-config (commit 
1e94d48801bf8cb75741aa308d4cdfb63b03c66c and 
01d742bc5cd22543d21edb2101fec6558d4075db) these seems to be device specific 
bindings that got accepted in the default config because the keys where unbound 
before.

Best regards,

Werner

>
> Regards,
>
> Hans
>
>