linux-kernel - Re: [tip: x86/fpu] x86/fpu: Use XSAVE{,OPT,C,S} and XRSTOR{,S} mnemonics in xstate.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250317184839.GIZ9huh0WS7cOFXz0X@fat_crate.local>
Date: Mon, 17 Mar 2025 19:48:39 +0100
From: Borislav Petkov <bp@...en8.de>
To: "H. Peter Anvin" <hpa@...or.com>
Cc: Uros Bizjak <ubizjak@...il.com>, linux-kernel@...r.kernel.org,
	linux-tip-commits@...r.kernel.org, Ingo Molnar <mingo@...nel.org>,
	Andy Lutomirski <luto@...nel.org>, Brian Gerst <brgerst@...il.com>,
	Dave Hansen <dave.hansen@...ux.intel.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>, x86@...nel.org
Subject: Re: [tip: x86/fpu] x86/fpu: Use XSAVE{,OPT,C,S} and XRSTOR{,S}
 mnemonics in xstate.h

On Mon, Mar 17, 2025 at 11:38:12AM -0700, H. Peter Anvin wrote:
> Ok, I'm going to argue, but only because the argument is called "st" and the
> assembly parameter "xa". That's needlessly different and means having to
> look extra hard 
> 
> We can obviously not use the same token, but IMO it would make a lot more
> sense to call one of them _st or perhaps st_p (being a pointer).

Already documented:

https://git.kernel.org/tip/4348e9177813656d5d8bd18f34b3e611df004032

Got tired of discussing the obvious.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette