linux-kernel - Re: [PATCH 4/9] dt-bindings: arm: qcom,coresight-static-replicator: add optional clocks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <174224068328.474126.11922746474259386307.robh@kernel.org>
Date: Mon, 17 Mar 2025 14:44:43 -0500
From: "Rob Herring (Arm)" <robh@...nel.org>
To: Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>
Cc: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>, 
 Abhinav Kumar <quic_abhinavk@...cinc.com>, 
 Conor Dooley <conor+dt@...nel.org>, 
 Marijn Suijten <marijn.suijten@...ainline.org>, 
 Georgi Djakov <djakov@...nel.org>, James Clark <james.clark@...aro.org>, 
 Bjorn Andersson <andersson@...nel.org>, Andy Gross <andy.gross@...aro.org>, 
 Simona Vetter <simona@...ll.ch>, linux-arm-kernel@...ts.infradead.org, 
 Leo Yan <leo.yan@...ux.dev>, Andy Gross <agross@...eaurora.org>, 
 devicetree@...r.kernel.org, dri-devel@...ts.freedesktop.org, 
 Konrad Dybcio <konradybcio@...nel.org>, David Airlie <airlied@...il.com>, 
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Lee Jones <lee@...nel.org>, 
 coresight@...ts.linaro.org, 
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>, 
 "Ivan T. Ivanov" <ivan.ivanov@...aro.org>, 
 Mike Leach <mike.leach@...aro.org>, Maxime Ripard <mripard@...nel.org>, 
 linux-kernel@...r.kernel.org, Rob Clark <robdclark@...il.com>, 
 Thomas Zimmermann <tzimmermann@...e.de>, David Heidelberg <david@...t.cz>, 
 freedreno@...ts.freedesktop.org, Sean Paul <sean@...rly.run>, 
 linux-arm-msm@...r.kernel.org, Neil Armstrong <neil.armstrong@...aro.org>, 
 Mathieu Poirier <mathieu.poirier@...aro.org>, 
 Suzuki K Poulose <suzuki.poulose@....com>, 
 Kumar Gala <galak@...eaurora.org>
Subject: Re: [PATCH 4/9] dt-bindings: arm:
 qcom,coresight-static-replicator: add optional clocks

On Mon, 17 Mar 2025 19:44:39 +0200, Dmitry Baryshkov wrote:
> As most other CoreSight devices the replicator can use either of the
> optional clocks (or both). Document those optional clocks in the schema.
> 
> Fixes: 3c15fddf3121 ("dt-bindings: arm: Convert CoreSight bindings to DT schema")
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>
> ---
>  .../bindings/arm/arm,coresight-static-replicator.yaml          | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/arm/arm,coresight-static-replicator.yaml: properties:clock-names: 'enum' should not be valid under {'enum': ['const', 'enum', 'exclusiveMaximum', 'exclusiveMinimum', 'minimum', 'maximum', 'multipleOf', 'pattern']}
	hint: Scalar and array keywords cannot be mixed
	from schema $id: http://devicetree.org/meta-schemas/keywords.yaml#

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250317-fix-nexus-4-v1-4-655c52e2ad97@oss.qualcomm.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.