linux-kernel - Re: [PATCH] media: i2c: lt6911uxe: Fix Kconfig dependencies:

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <3bb730a9-5d8a-41c6-8a27-e099561b5890@app.fastmail.com>
Date: Mon, 17 Mar 2025 11:32:13 +0100
From: "Arnd Bergmann" <arnd@...db.de>
To: "Yan, Dongcheng" <dongcheng.yan@...el.com>,
 "Arnd Bergmann" <arnd@...nel.org>,
 "Mauro Carvalho Chehab" <mchehab@...nel.org>,
 "Hans Verkuil" <hverkuil@...all.nl>
Cc: "Sakari Ailus" <sakari.ailus@...ux.intel.com>,
 "laurent.pinchart" <laurent.pinchart@...asonboard.com>,
 "Umang Jain" <umang.jain@...asonboard.com>, linux-media@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] media: i2c: lt6911uxe: Fix Kconfig dependencies:

On Mon, Mar 17, 2025, at 11:17, Yan, Dongcheng wrote:
> On 3/14/2025 11:46 PM, Arnd Bergmann wrote:
>> From: Arnd Bergmann <arnd@...db.de>

>> @@ -1149,8 +1149,9 @@ config VIDEO_ISL7998X
>>  
>>  config VIDEO_LT6911UXE
>>  	tristate "Lontium LT6911UXE decoder"
>> -	depends on ACPI && VIDEO_DEV
>> +	depends on ACPI && VIDEO_DEV && I2C
>>  	select V4L2_FWNODE
>> +	select V4L2_CCI_I2C
>>  	help
>>  	  This is a Video4Linux2 sensor-level driver for the Lontium
>>  	  LT6911UXE HDMI to MIPI CSI-2 bridge.
>
> Thanks for your fix.
>
> Lkp is a bit weird to me, because it tested a warning in patch v6 likes
> below:
>
>     kismet: WARNING: unmet direct dependencies detected for V4L2_CCI_I2C
> when selected by VIDEO_LT6911UXE

What was the full warning? The only dependency I see in V4L2_CCI_I2C
is CONFIG_I2C itself, and that is what I add above.

> So I remove this select flag and passed lkp build test in patch v7.
> But now it encounters build error again, I'm curious why...

I don't currently get any more build errors with my patch
added in, and I think this should be sufficient. Can you forward
me the errors and config you get with my patch?

     Arnd