linux-kernel - Re: [PATCH] media: i2c: lt6911uxe: Fix Kconfig dependencies:

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ecb959fe-69e3-4265-9e4b-326bff421153@intel.com>
Date: Mon, 17 Mar 2025 18:17:23 +0800
From: "Yan, Dongcheng" <dongcheng.yan@...el.com>
To: Arnd Bergmann <arnd@...nel.org>,
 Mauro Carvalho Chehab <mchehab@...nel.org>, Hans Verkuil <hverkuil@...all.nl>
Cc: Arnd Bergmann <arnd@...db.de>, Sakari Ailus
 <sakari.ailus@...ux.intel.com>,
 Laurent Pinchart <laurent.pinchart@...asonboard.com>,
 Umang Jain <umang.jain@...asonboard.com>, linux-media@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] media: i2c: lt6911uxe: Fix Kconfig dependencies:

Hi Arnd,

On 3/14/2025 11:46 PM, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> The new driver fails to build if I2C is disabled:
> 
> drivers/media/i2c/lt6911uxe.c:703:1: error: data definition has no type or storage class [-Werror]
>   703 | module_i2c_driver(lt6911uxe_i2c_driver);
> 
> or if I2C is on but V4L2_CCI_I2C is not:
> 
> ERROR: modpost: "cci_write" [drivers/media/i2c/lt6911uxe.ko] undefined!
> ERROR: modpost: "cci_read" [drivers/media/i2c/lt6911uxe.ko] undefined!
> 
> For both by adding a dependency on I2C and selecting V4L2_CCI_I2C, which
> follows the common practice for these.
> 
> Fixes: e49563c3be09 ("media: i2c: add lt6911uxe hdmi bridge driver")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>  drivers/media/i2c/Kconfig | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig
> index e576b213084d..b06365d02ef1 100644
> --- a/drivers/media/i2c/Kconfig
> +++ b/drivers/media/i2c/Kconfig
> @@ -1149,8 +1149,9 @@ config VIDEO_ISL7998X
>  
>  config VIDEO_LT6911UXE
>  	tristate "Lontium LT6911UXE decoder"
> -	depends on ACPI && VIDEO_DEV
> +	depends on ACPI && VIDEO_DEV && I2C
>  	select V4L2_FWNODE
> +	select V4L2_CCI_I2C
>  	help
>  	  This is a Video4Linux2 sensor-level driver for the Lontium
>  	  LT6911UXE HDMI to MIPI CSI-2 bridge.

Thanks for your fix.

Lkp is a bit weird to me, because it tested a warning in patch v6 likes
below:

    kismet: WARNING: unmet direct dependencies detected for V4L2_CCI_I2C
when selected by VIDEO_LT6911UXE

So I remove this select flag and passed lkp build test in patch v7.
But now it encounters build error again, I'm curious why...

Thanks,
Dongcheng