linux-kernel - [PATCH] rtc: pm8xxx: switch to devm_device_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250317111312.1518349-1-alexandre.belloni@bootlin.com>
Date: Mon, 17 Mar 2025 12:13:11 +0100
From: alexandre.belloni@...tlin.com
To: Johan Hovold <johan+linaro@...nel.org>,
	Alexandre Belloni <alexandre.belloni@...tlin.com>
Cc: linux-arm-msm@...r.kernel.org,
	linux-rtc@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: [PATCH] rtc: pm8xxx: switch to devm_device_init_wakeup

From: Alexandre Belloni <alexandre.belloni@...tlin.com>

Switch to devm_device_init_wakeup to avoid a possible memory leak as wakeup
is never disabled.

Signed-off-by: Alexandre Belloni <alexandre.belloni@...tlin.com>
---
 drivers/rtc/rtc-pm8xxx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/rtc/rtc-pm8xxx.c b/drivers/rtc/rtc-pm8xxx.c
index c6241a0c26e9..70cbac76147b 100644
--- a/drivers/rtc/rtc-pm8xxx.c
+++ b/drivers/rtc/rtc-pm8xxx.c
@@ -647,7 +647,7 @@ static int pm8xxx_rtc_probe(struct platform_device *pdev)
 		if (rc)
 			return rc;
 
-		device_init_wakeup(&pdev->dev, true);
+		devm_device_init_wakeup(&pdev->dev);
 	} else {
 		clear_bit(RTC_FEATURE_ALARM, rtc_dd->rtc->features);
 	}
-- 
2.48.1