linux-kernel - Re: [PATCH] rtc: pm8xxx: switch to devm_device_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z9gOT5WBaGkBZjl9@hovoldconsulting.com>
Date: Mon, 17 Mar 2025 12:58:07 +0100
From: Johan Hovold <johan@...nel.org>
To: alexandre.belloni@...tlin.com
Cc: Johan Hovold <johan+linaro@...nel.org>, linux-arm-msm@...r.kernel.org,
	linux-rtc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] rtc: pm8xxx: switch to devm_device_init_wakeup

On Mon, Mar 17, 2025 at 12:13:11PM +0100, alexandre.belloni@...tlin.com wrote:
> From: Alexandre Belloni <alexandre.belloni@...tlin.com>
> 
> Switch to devm_device_init_wakeup to avoid a possible memory leak as wakeup
> is never disabled.

You should probably mention that this was due to a bad merge. The
no-alarm patch moved the previous call to device_init_wakeup() into the
conditional, but you had switched it to use devres so we ended up with
two calls when you applied the patch.

Unless you want to and can rebase your tree.

> Signed-off-by: Alexandre Belloni <alexandre.belloni@...tlin.com>
> ---
>  drivers/rtc/rtc-pm8xxx.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/rtc/rtc-pm8xxx.c b/drivers/rtc/rtc-pm8xxx.c
> index c6241a0c26e9..70cbac76147b 100644
> --- a/drivers/rtc/rtc-pm8xxx.c
> +++ b/drivers/rtc/rtc-pm8xxx.c
> @@ -647,7 +647,7 @@ static int pm8xxx_rtc_probe(struct platform_device *pdev)
>  		if (rc)
>  			return rc;
>  
> -		device_init_wakeup(&pdev->dev, true);
> +		devm_device_init_wakeup(&pdev->dev);

So you need to remove the call to devm_device_init_wakeup() above as
well (after platform_set_drvdata()) which the no-alarm patch moved here.

With that fixed:

Reviewed-by: Johan Hovold <johan+linaro@...nel.org>

>  	} else {
>  		clear_bit(RTC_FEATURE_ALARM, rtc_dd->rtc->features);
>  	}

Johan