linux-kernel - Re: [PATCH] smb: client: Remove redundant check in smb2_is_path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAH2r5msSqt7iJ9rCFDWZqTbG5o85nbM3Ucx73w-YwBLKbr4cXw@mail.gmail.com>
Date: Tue, 18 Mar 2025 14:23:19 -0500
From: Steve French <smfrench@...il.com>
To: Ivan Abramov <i.abramov@...integration.ru>
Cc: Steve French <sfrench@...ba.org>, Paulo Alcantara <pc@...guebit.com>, 
	Ronnie Sahlberg <ronniesahlberg@...il.com>, Shyam Prasad N <sprasad@...rosoft.com>, 
	Tom Talpey <tom@...pey.com>, Bharath SM <bharathsm@...rosoft.com>, linux-cifs@...r.kernel.org, 
	samba-technical@...ts.samba.org, linux-kernel@...r.kernel.org, 
	lvc-project@...uxtesting.org
Subject: Re: [PATCH] smb: client: Remove redundant check in smb2_is_path_accessible()

merged both patches into cifs-2.6.git for-next pending additional testing

On Mon, Mar 10, 2025 at 9:05 AM Ivan Abramov
<i.abramov@...integration.ru> wrote:
>
> There is an unnecessary NULL check of cifs_sb in smb2_is_path_accessible(),
> since cifs_sb is dereferenced multiple times prior to it.
>
> It seems that there is no need to introduce any NULL checks of cifs_sb,
> since arguments of smb2_is_path_accessible() are assumed to be non-NULL.
>
> Therefore, this redundant check can be removed.
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
> Signed-off-by: Ivan Abramov <i.abramov@...integration.ru>
> ---
>  fs/smb/client/smb2ops.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/smb/client/smb2ops.c b/fs/smb/client/smb2ops.c
> index 4dd11eafb69d..6958825431af 100644
> --- a/fs/smb/client/smb2ops.c
> +++ b/fs/smb/client/smb2ops.c
> @@ -969,7 +969,7 @@ smb2_is_path_accessible(const unsigned int xid, struct cifs_tcon *tcon,
>                         if (islink)
>                                 rc = -EREMOTE;
>                 }
> -               if (rc == -EREMOTE && IS_ENABLED(CONFIG_CIFS_DFS_UPCALL) && cifs_sb &&
> +               if (rc == -EREMOTE && IS_ENABLED(CONFIG_CIFS_DFS_UPCALL) &&
>                     (cifs_sb->mnt_cifs_flags & CIFS_MOUNT_NO_DFS))
>                         rc = -EOPNOTSUPP;
>                 goto out;
> --
> 2.39.5
>
>


-- 
Thanks,

Steve