linux-kernel - Re: [PATCH linux-next] net: atm: use sysfs_emit()/sysfs_emit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <46a0a5e2-2def-4ed1-ab54-40b6c8393239@engleder-embedded.com>
Date: Tue, 18 Mar 2025 19:58:29 +0100
From: Gerhard Engleder <gerhard@...leder-embedded.com>
To: xie.ludan@....com.cn
Cc: edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
 horms@...nel.org, netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
 xu.xin16@....com.cn, yang.yang29@....com.cn, davem@...emloft.net
Subject: Re: [PATCH linux-next] net: atm: use sysfs_emit()/sysfs_emit_at()
 instead of scnprintf().

On 17.03.25 08:29, xie.ludan@....com.cn wrote:
> From: XieLudan <xie.ludan@....com.cn>
> 
> Follow the advice in Documentation/filesystems/sysfs.rst:
> show() should only use sysfs_emit() or sysfs_emit_at() when formatting
> the value to be returned to user space.
> 
> Signed-off-by: XieLudan <xie.ludan@....com.cn>
> ---
>   net/atm/atm_sysfs.c | 12 ++++++------
>   1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/net/atm/atm_sysfs.c b/net/atm/atm_sysfs.c
> index 54e7fb1a4ee5..ae0d921157c5 100644
> --- a/net/atm/atm_sysfs.c
> +++ b/net/atm/atm_sysfs.c
> @@ -16,7 +16,7 @@ static ssize_t type_show(struct device *cdev,
>   {
>   	struct atm_dev *adev = to_atm_dev(cdev);
> 
> -	return scnprintf(buf, PAGE_SIZE, "%s\n", adev->type);
> +	return sysfs_emit(buf, "%s\n", adev->type);
>   }
> 
>   static ssize_t address_show(struct device *cdev,
> @@ -24,7 +24,7 @@ static ssize_t address_show(struct device *cdev,
>   {
>   	struct atm_dev *adev = to_atm_dev(cdev);
> 
> -	return scnprintf(buf, PAGE_SIZE, "%pM\n", adev->esi);
> +	return sysfs_emit(buf, "%pM\n", adev->esi);
>   }
> 
>   static ssize_t atmaddress_show(struct device *cdev,
> @@ -37,7 +37,7 @@ static ssize_t atmaddress_show(struct device *cdev,
> 
>   	spin_lock_irqsave(&adev->lock, flags);
>   	list_for_each_entry(aaddr, &adev->local, entry) {
> -		count += scnprintf(buf + count, PAGE_SIZE - count,
> +		count += sysfs_emit_at(buf, count,
>   				   "%1phN.%2phN.%10phN.%6phN.%1phN\n",
>   				   &aaddr->addr.sas_addr.prv[0],
>   				   &aaddr->addr.sas_addr.prv[1],

Does the alignment of the following argument lines needs to be adapted?

> @@ -55,7 +55,7 @@ static ssize_t atmindex_show(struct device *cdev,
>   {
>   	struct atm_dev *adev = to_atm_dev(cdev);
> 
> -	return scnprintf(buf, PAGE_SIZE, "%d\n", adev->number);
> +	return sysfs_emit(buf, "%d\n", adev->number);
>   }
> 
>   static ssize_t carrier_show(struct device *cdev,
> @@ -63,7 +63,7 @@ static ssize_t carrier_show(struct device *cdev,
>   {
>   	struct atm_dev *adev = to_atm_dev(cdev);
> 
> -	return scnprintf(buf, PAGE_SIZE, "%d\n",
> +	return sysfs_emit(buf, "%d\n",
>   			 adev->signal == ATM_PHY_SIG_LOST ? 0 : 1);

Adapt alignment of following line?

Gerhard