linux-kernel - Re: [PATCH v4 3/3] soc: aspeed: lpc-pcc: Add PCC controller support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3270a7ea55fa28253b435da0b0bbce3adfdc00eb.camel@codeconstruct.com.au>
Date: Tue, 18 Mar 2025 11:12:09 +1030
From: Andrew Jeffery <andrew@...econstruct.com.au>
To: Kevin Chen <kevin_chen@...eedtech.com>, lee@...nel.org, robh@...nel.org,
  krzk+dt@...nel.org, conor+dt@...nel.org, joel@....id.au,
 derek.kiernan@....com,  dragan.cvetic@....com, arnd@...db.de,
 gregkh@...uxfoundation.org,  devicetree@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org,  linux-aspeed@...ts.ozlabs.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 3/3] soc: aspeed: lpc-pcc: Add PCC controller support

On Fri, 2025-03-14 at 19:21 +0800, Kevin Chen wrote:
> +       pcc->mdev.parent = dev;
> +       pcc->mdev.minor = MISC_DYNAMIC_MINOR;
> +       pcc->mdev.name = devm_kasprintf(dev, GFP_KERNEL, "%s%d",
> DEVICE_NAME,
> +                                       pcc->mdev_id);
> +       pcc->mdev.fops = &pcc_fops;
> +       rc = misc_register(&pcc->mdev);
> +       if (rc) {
> +               dev_err(dev, "Couldn't register misc device\n");
> +               goto err_free_ida;
> +       }

Just a note that this still isn't accounting for discussion on the
previous posting of the series putting the driver under
drivers/soc/aspeed:

https://lore.kernel.org/all/f7369d6205e05c7aac3f3de7cbd08c3b08960d75.camel@codeconstruct.com.au/

If we're not going to try make a common userspace behaviour over the
Aspeed snoop and PCC functions and the Nuvoton BPC function then I
think the behaviour of the chardev should at least be documented. But I
would rather that it were common to avoid headaches in userspace.

Andrew