linux-kernel - Re: [PATCH v1 1/2] media: dt-bindings: Add qcom,qcs8300-camss

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <f2899540-f9ac-4013-a703-25800429f97d@kernel.org>
Date: Tue, 18 Mar 2025 08:16:11 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Vikram Sharma <quic_vikramsa@...cinc.com>
Cc: rfoss@...nel.org, todor.too@...il.com, bryan.odonoghue@...aro.org,
 mchehab@...nel.org, robh@...nel.org, krzk+dt@...nel.org,
 conor+dt@...nel.org, andersson@...nel.org, konradybcio@...nel.org,
 hverkuil-cisco@...all.nl, cros-qcom-dts-watchers@...omium.org,
 catalin.marinas@....com, will@...nel.org,
 linux-arm-kernel@...ts.infradead.org, linux-media@...r.kernel.org,
 linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 1/2] media: dt-bindings: Add qcom,qcs8300-camss

On 18/03/2025 06:52, Vikram Sharma wrote:
> 
> On 2/23/2025 5:03 PM, Krzysztof Kozlowski wrote:
>> On Fri, Feb 14, 2025 at 03:17:46PM +0530, Vikram Sharma wrote:
>>> +properties:
>>> +  compatible:
>>> +    const: qcom,qcs8300-camss
>>> +
>>> +  reg:
>>> +    maxItems: 21
>>> +
>>> +  reg-names:
>>> +    items:
>>> +      - const: csid_wrapper
>> Why different order of entries than sm8550?
> 
> Hi Krzysztof,
> 
> Thanks for your review.
> I did this change to address a comment from Bryan on another series.
> https://lore.kernel.org/linux-arm-msm/e152ff78-caa5-493a-88da-96a6670eb2a2@linaro.org/
> 
> Please suggest if I should keep the order same as sm8550?
If you chosen the same order as x1e80100 then it is fine, but that file
is not merged so it is your responsibility to track any differences and
be sure whatever you send is always in sync with x1e.

Best regards,
Krzysztof