[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Z9kwIYrOwO8nOpAE@gmail.com>
Date: Tue, 18 Mar 2025 09:34:41 +0100
From: Ingo Molnar <mingo@...nel.org>
To: Xin Li <xin@...or.com>
Cc: linux-kernel@...r.kernel.org, Juergen Gross <jgross@...e.com>,
Stefano Stabellini <sstabellini@...nel.org>,
"Ahmed S . Darwish" <darwi@...utronix.de>,
Andrew Cooper <andrew.cooper3@...rix.com>,
"H . Peter Anvin" <hpa@...or.com>,
John Ogness <john.ogness@...utronix.de>,
Linus Torvalds <torvalds@...ux-foundation.org>,
Peter Zijlstra <peterz@...radead.org>,
Borislav Petkov <bp@...en8.de>,
Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH 5/5] x86/cpuid: Use u32 in instead of uint32_t in
<asm/cpuid/api.h>
* Xin Li <xin@...or.com> wrote:
> On 3/17/2025 3:18 PM, Ingo Molnar wrote:
> > Use u32 instead of uint32_t in hypervisor_cpuid_base().
> >
> > Yes, I realize uint32_t is used in Xen code et al, but this is
> > a core x86 architecture header and we should standardize on the
>
> no "we", right?
That's a stupid rule, I don't know where it came from, and I never
enforced it. It's not in Documentation/process/coding-style.rst.
Linus doesn't use this pointless rule of 'pronoun avoidance' in
changelogs either:
00a7d39898c8 ("fs/pipe: add simpler helpers for common cases")
https://web.git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=00a7d39898c8010bfd5ff62af31ca5db34421b38
It turns out that we don't have _that_ many places that access these
^^
fields directly and were affected, but we have more than we strictly
^^ ^^
should have, because our low-level helper functions have been designed
to have intimate knowledge of how the pipes work.
And as a result, that random noise of direct 'pipe->head' and
'pipe->tail' accesses makes it harder to pinpoint any actual potential
problem spots remaining.
For example, we didn't have a "is the pipe full" helper function, but
^^
instead had a "given these pipe buffer indexes and this pipe size, is
the pipe full". That's because some low-level pipe code does actually
want that much more complicated interface.
In changelogs 'we' when used as a generic personal pronoun means the
kernel and the kernel community in general. It's a perfectly fine
grammatical construct.
Thanks,
Ingo
Powered by blists - more mailing lists