linux-kernel - Re: [PATCH] ASoC: Add initialization for wm8997 component

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z9k/U+8TSVfSzFKw@opensource.cirrus.com>
Date: Tue, 18 Mar 2025 09:39:31 +0000
From: Charles Keepax <ckeepax@...nsource.cirrus.com>
To: Wentao Liang <vulab@...as.ac.cn>
CC: <lgirdwood@...il.com>, <broonie@...nel.org>, <perex@...ex.cz>,
        <tiwai@...e.com>, <u.kleine-koenig@...libre.com>,
        <patches@...nsource.cirrus.com>, <linux-sound@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ASoC: Add initialization for wm8997 component

On Mon, Mar 17, 2025 at 10:08:44PM +0800, Wentao Liang wrote:
> In wm8997_component_probe(), wm8997 should be initialized by
> arizona_init_gpio(). A proper implementation can be found in
> 'wm8998_component_probe()' where the wm8998 component is
> initialized with arizona_init_gpio().
> 
> Signed-off-by: Wentao Liang <vulab@...as.ac.cn>
> ---
>  sound/soc/codecs/wm8997.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/sound/soc/codecs/wm8997.c b/sound/soc/codecs/wm8997.c
> index 5389c363b14e..ef8e09cc7211 100644
> --- a/sound/soc/codecs/wm8997.c
> +++ b/sound/soc/codecs/wm8997.c
> @@ -1066,6 +1066,8 @@ static int wm8997_component_probe(struct snd_soc_component *component)
>  	if (ret < 0)
>  		return ret;
>  
> +	arizona_init_gpio(component);
> +

This is not a missing initialisation, arizona_init_gpios hooks up
the signal detect feature. I am not certain it is worth adding the
signal detect feature to wm8997 at this point given I am not even
sure it shipped any units. If you do actually have a reason for
doing so, this is not sufficient to enable the feature. You need
to also add the Signal Detect widgets and routes.

Thanks,
Charles