linux-kernel - Re: [PATCH net-next v4 01/10] net: usb: lan78xx: handle errors in lan7801 PHY initialization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250318-friendly-victorious-bustard-fcfbfe-mkl@pengutronix.de>
Date: Tue, 18 Mar 2025 10:39:55 +0100
From: Marc Kleine-Budde <mkl@...gutronix.de>
To: Oleksij Rempel <o.rempel@...gutronix.de>
Cc: "David S. Miller" <davem@...emloft.net>, 
	Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, 
	Paolo Abeni <pabeni@...hat.com>, Woojung Huh <woojung.huh@...rochip.com>, 
	Andrew Lunn <andrew+netdev@...n.ch>, Russell King <rmk+kernel@...linux.org.uk>, 
	Thangaraj Samynathan <Thangaraj.S@...rochip.com>, Rengarajan Sundararajan <Rengarajan.S@...rochip.com>, 
	Simon Horman <horms@...nel.org>, netdev@...r.kernel.org, Phil Elwell <phil@...pberrypi.org>, 
	linux-kernel@...r.kernel.org, UNGLinuxDriver@...rochip.com, kernel@...gutronix.de, 
	Maxime Chevallier <maxime.chevallier@...tlin.com>
Subject: Re: [PATCH net-next v4 01/10] net: usb: lan78xx: handle errors in
 lan7801 PHY initialization

On 18.03.2025 10:34:01, Oleksij Rempel wrote:
> Add error handling for `lan78xx_write_reg()` and `lan78xx_read_reg()`
> in `lan7801_phy_init()`. If any register operation fails, return
> an appropriate error using `ERR_PTR(ret)` to prevent further execution
> with invalid configurations.

You have to convert the caller of lan7801_phy_init(), too. AFICS it
checks for NULL only.

Marc

> Signed-off-by: Oleksij Rempel <o.rempel@...gutronix.de>
> ---
>  drivers/net/usb/lan78xx.c | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/drivers/net/usb/lan78xx.c b/drivers/net/usb/lan78xx.c
> index 137adf6d5b08..d03668c2c1c9 100644
> --- a/drivers/net/usb/lan78xx.c
> +++ b/drivers/net/usb/lan78xx.c
> @@ -2531,11 +2531,22 @@ static struct phy_device *lan7801_phy_init(struct lan78xx_net *dev)
>  		dev->interface = PHY_INTERFACE_MODE_RGMII;
>  		ret = lan78xx_write_reg(dev, MAC_RGMII_ID,
>  					MAC_RGMII_ID_TXC_DELAY_EN_);
> +		if (ret < 0)
> +			return ERR_PTR(ret);
> +
>  		ret = lan78xx_write_reg(dev, RGMII_TX_BYP_DLL, 0x3D00);
> +		if (ret < 0)
> +			return ERR_PTR(ret);
> +
>  		ret = lan78xx_read_reg(dev, HW_CFG, &buf);
> +		if (ret < 0)
> +			return ERR_PTR(ret);
> +
>  		buf |= HW_CFG_CLK125_EN_;
>  		buf |= HW_CFG_REFCLK25_EN_;
>  		ret = lan78xx_write_reg(dev, HW_CFG, buf);
> +		if (ret < 0)
> +			return ERR_PTR(ret);
>  	} else {
>  		if (!phydev->drv) {
>  			netdev_err(dev->net, "no PHY driver found\n");
> -- 
> 2.39.5
> 
> 
> 

-- 
Pengutronix e.K.                 | Marc Kleine-Budde          |
Embedded Linux                   | https://www.pengutronix.de |
Vertretung Nürnberg              | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-9   |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)