lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20250318-belligerent-emu-of-authority-0beddf-mkl@pengutronix.de>
Date: Tue, 18 Mar 2025 10:42:22 +0100
From: Marc Kleine-Budde <mkl@...gutronix.de>
To: Oleksij Rempel <o.rempel@...gutronix.de>
Cc: "David S. Miller" <davem@...emloft.net>, 
	Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, 
	Paolo Abeni <pabeni@...hat.com>, Woojung Huh <woojung.huh@...rochip.com>, 
	Andrew Lunn <andrew+netdev@...n.ch>, Russell King <rmk+kernel@...linux.org.uk>, 
	Thangaraj Samynathan <Thangaraj.S@...rochip.com>, Rengarajan Sundararajan <Rengarajan.S@...rochip.com>, 
	Simon Horman <horms@...nel.org>, netdev@...r.kernel.org, Phil Elwell <phil@...pberrypi.org>, 
	linux-kernel@...r.kernel.org, UNGLinuxDriver@...rochip.com, kernel@...gutronix.de, 
	Maxime Chevallier <maxime.chevallier@...tlin.com>
Subject: Re: [PATCH net-next v4 04/10] net: usb: lan78xx: improve error
 reporting on PHY attach failure

On 18.03.2025 10:34:04, Oleksij Rempel wrote:
> Include error code in the log message when PHY attachment fails,
> providing better debugging information.
> 
> Signed-off-by: Oleksij Rempel <o.rempel@...gutronix.de>
> ---
> changes v3:
> - update commit message
> ---
>  drivers/net/usb/lan78xx.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/usb/lan78xx.c b/drivers/net/usb/lan78xx.c
> index e54b1ac2c4fc..d2bc6cbdbb66 100644
> --- a/drivers/net/usb/lan78xx.c
> +++ b/drivers/net/usb/lan78xx.c
> @@ -2693,8 +2693,8 @@ static int lan78xx_phy_init(struct lan78xx_net *dev)
>  
>  	ret = phylink_connect_phy(dev->phylink, phydev);
>  	if (ret) {
> -		netdev_err(dev->net, "can't attach PHY to %s\n",
> -			   dev->mdiobus->id);
> +		netdev_err(dev->net, "can't attach PHY to %s, error %pe\n",
> +			   dev->mdiobus->id, ERR_PTR(ret));
>  		return -EIO;

Probably unrelated to this patch, but what about propagating the error
value?

Marc

>  	}
>  
> -- 
> 2.39.5
> 
> 
> 

-- 
Pengutronix e.K.                 | Marc Kleine-Budde          |
Embedded Linux                   | https://www.pengutronix.de |
Vertretung Nürnberg              | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-9   |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ