| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <202503192340.iVN44lM2-lkp@intel.com>
Date: Wed, 19 Mar 2025 23:37:19 +0800
From: kernel test robot <lkp@...el.com>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
linux-usb@...r.kernel.org, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org
Cc: oe-kbuild-all@...ts.linux.dev, Andrew Lunn <andrew+netdev@...n.ch>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
Heiner Kallweit <hkallweit1@...il.com>,
Russell King <linux@...linux.org.uk>
Subject: Re: [PATCH net v2 1/2] net: phy: Fix formatting specifier to avoid
potential string cuts
Hi Andy,
kernel test robot noticed the following build warnings:
[auto build test WARNING on net/main]
url: https://github.com/intel-lab-lkp/linux/commits/Andy-Shevchenko/net-phy-Fix-formatting-specifier-to-avoid-potential-string-cuts/20250319-190433
base: net/main
patch link: https://lore.kernel.org/r/20250319105813.3102076-2-andriy.shevchenko%40linux.intel.com
patch subject: [PATCH net v2 1/2] net: phy: Fix formatting specifier to avoid potential string cuts
config: x86_64-allmodconfig (https://download.01.org/0day-ci/archive/20250319/202503192340.iVN44lM2-lkp@intel.com/config)
compiler: clang version 20.1.0 (https://github.com/llvm/llvm-project 24a30daaa559829ad079f2ff7f73eb4e18095f88)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250319/202503192340.iVN44lM2-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202503192340.iVN44lM2-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> drivers/net/usb/ax88172a.c:312:20: warning: format specifies type 'unsigned char' but the argument has type 'u16' (aka 'unsigned short') [-Wformat]
311 | snprintf(priv->phy_name, 20, PHY_ID_FMT,
| ~~~~~~~~~~
312 | priv->mdio->id, priv->phy_addr);
| ^~~~~~~~~~~~~~
1 warning generated.
vim +312 drivers/net/usb/ax88172a.c
16626b0cc3d5af Christian Riesch 2012-07-13 260
16626b0cc3d5af Christian Riesch 2012-07-13 261 static int ax88172a_reset(struct usbnet *dev)
16626b0cc3d5af Christian Riesch 2012-07-13 262 {
16626b0cc3d5af Christian Riesch 2012-07-13 263 struct asix_data *data = (struct asix_data *)&dev->data;
16626b0cc3d5af Christian Riesch 2012-07-13 264 struct ax88172a_private *priv = dev->driver_priv;
16626b0cc3d5af Christian Riesch 2012-07-13 265 int ret;
16626b0cc3d5af Christian Riesch 2012-07-13 266 u16 rx_ctl;
16626b0cc3d5af Christian Riesch 2012-07-13 267
16626b0cc3d5af Christian Riesch 2012-07-13 268 ax88172a_reset_phy(dev, priv->use_embdphy);
16626b0cc3d5af Christian Riesch 2012-07-13 269
16626b0cc3d5af Christian Riesch 2012-07-13 270 msleep(150);
d9fe64e511144c Robert Foss 2016-08-29 271 rx_ctl = asix_read_rx_ctl(dev, 0);
16626b0cc3d5af Christian Riesch 2012-07-13 272 netdev_dbg(dev->net, "RX_CTL is 0x%04x after software reset\n", rx_ctl);
d9fe64e511144c Robert Foss 2016-08-29 273 ret = asix_write_rx_ctl(dev, 0x0000, 0);
16626b0cc3d5af Christian Riesch 2012-07-13 274 if (ret < 0)
16626b0cc3d5af Christian Riesch 2012-07-13 275 goto out;
16626b0cc3d5af Christian Riesch 2012-07-13 276
d9fe64e511144c Robert Foss 2016-08-29 277 rx_ctl = asix_read_rx_ctl(dev, 0);
16626b0cc3d5af Christian Riesch 2012-07-13 278 netdev_dbg(dev->net, "RX_CTL is 0x%04x setting to 0x0000\n", rx_ctl);
16626b0cc3d5af Christian Riesch 2012-07-13 279
16626b0cc3d5af Christian Riesch 2012-07-13 280 msleep(150);
16626b0cc3d5af Christian Riesch 2012-07-13 281
16626b0cc3d5af Christian Riesch 2012-07-13 282 ret = asix_write_cmd(dev, AX_CMD_WRITE_IPG0,
16626b0cc3d5af Christian Riesch 2012-07-13 283 AX88772_IPG0_DEFAULT | AX88772_IPG1_DEFAULT,
d9fe64e511144c Robert Foss 2016-08-29 284 AX88772_IPG2_DEFAULT, 0, NULL, 0);
16626b0cc3d5af Christian Riesch 2012-07-13 285 if (ret < 0) {
16626b0cc3d5af Christian Riesch 2012-07-13 286 netdev_err(dev->net, "Write IPG,IPG1,IPG2 failed: %d\n", ret);
16626b0cc3d5af Christian Riesch 2012-07-13 287 goto out;
16626b0cc3d5af Christian Riesch 2012-07-13 288 }
16626b0cc3d5af Christian Riesch 2012-07-13 289
16626b0cc3d5af Christian Riesch 2012-07-13 290 /* Rewrite MAC address */
16626b0cc3d5af Christian Riesch 2012-07-13 291 memcpy(data->mac_addr, dev->net->dev_addr, ETH_ALEN);
16626b0cc3d5af Christian Riesch 2012-07-13 292 ret = asix_write_cmd(dev, AX_CMD_WRITE_NODE_ID, 0, 0, ETH_ALEN,
d9fe64e511144c Robert Foss 2016-08-29 293 data->mac_addr, 0);
16626b0cc3d5af Christian Riesch 2012-07-13 294 if (ret < 0)
16626b0cc3d5af Christian Riesch 2012-07-13 295 goto out;
16626b0cc3d5af Christian Riesch 2012-07-13 296
16626b0cc3d5af Christian Riesch 2012-07-13 297 /* Set RX_CTL to default values with 2k buffer, and enable cactus */
d9fe64e511144c Robert Foss 2016-08-29 298 ret = asix_write_rx_ctl(dev, AX_DEFAULT_RX_CTL, 0);
16626b0cc3d5af Christian Riesch 2012-07-13 299 if (ret < 0)
16626b0cc3d5af Christian Riesch 2012-07-13 300 goto out;
16626b0cc3d5af Christian Riesch 2012-07-13 301
d9fe64e511144c Robert Foss 2016-08-29 302 rx_ctl = asix_read_rx_ctl(dev, 0);
16626b0cc3d5af Christian Riesch 2012-07-13 303 netdev_dbg(dev->net, "RX_CTL is 0x%04x after all initializations\n",
16626b0cc3d5af Christian Riesch 2012-07-13 304 rx_ctl);
16626b0cc3d5af Christian Riesch 2012-07-13 305
d9fe64e511144c Robert Foss 2016-08-29 306 rx_ctl = asix_read_medium_status(dev, 0);
16626b0cc3d5af Christian Riesch 2012-07-13 307 netdev_dbg(dev->net, "Medium Status is 0x%04x after all initializations\n",
16626b0cc3d5af Christian Riesch 2012-07-13 308 rx_ctl);
16626b0cc3d5af Christian Riesch 2012-07-13 309
16626b0cc3d5af Christian Riesch 2012-07-13 310 /* Connect to PHY */
16626b0cc3d5af Christian Riesch 2012-07-13 311 snprintf(priv->phy_name, 20, PHY_ID_FMT,
16626b0cc3d5af Christian Riesch 2012-07-13 @312 priv->mdio->id, priv->phy_addr);
16626b0cc3d5af Christian Riesch 2012-07-13 313
16626b0cc3d5af Christian Riesch 2012-07-13 314 priv->phydev = phy_connect(dev->net, priv->phy_name,
16626b0cc3d5af Christian Riesch 2012-07-13 315 &ax88172a_adjust_link,
f9a8f83b04e0c3 Florian Fainelli 2013-01-14 316 PHY_INTERFACE_MODE_MII);
16626b0cc3d5af Christian Riesch 2012-07-13 317 if (IS_ERR(priv->phydev)) {
16626b0cc3d5af Christian Riesch 2012-07-13 318 netdev_err(dev->net, "Could not connect to PHY device %s\n",
16626b0cc3d5af Christian Riesch 2012-07-13 319 priv->phy_name);
16626b0cc3d5af Christian Riesch 2012-07-13 320 ret = PTR_ERR(priv->phydev);
16626b0cc3d5af Christian Riesch 2012-07-13 321 goto out;
16626b0cc3d5af Christian Riesch 2012-07-13 322 }
16626b0cc3d5af Christian Riesch 2012-07-13 323
16626b0cc3d5af Christian Riesch 2012-07-13 324 netdev_info(dev->net, "Connected to phy %s\n", priv->phy_name);
16626b0cc3d5af Christian Riesch 2012-07-13 325
16626b0cc3d5af Christian Riesch 2012-07-13 326 /* During power-up, the AX88172A set the power down (BMCR_PDOWN)
16626b0cc3d5af Christian Riesch 2012-07-13 327 * bit of the PHY. Bring the PHY up again.
16626b0cc3d5af Christian Riesch 2012-07-13 328 */
16626b0cc3d5af Christian Riesch 2012-07-13 329 genphy_resume(priv->phydev);
16626b0cc3d5af Christian Riesch 2012-07-13 330 phy_start(priv->phydev);
16626b0cc3d5af Christian Riesch 2012-07-13 331
16626b0cc3d5af Christian Riesch 2012-07-13 332 return 0;
16626b0cc3d5af Christian Riesch 2012-07-13 333
16626b0cc3d5af Christian Riesch 2012-07-13 334 out:
16626b0cc3d5af Christian Riesch 2012-07-13 335 return ret;
16626b0cc3d5af Christian Riesch 2012-07-13 336
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
Powered by blists - more mailing lists