linux-kernel - Re: [PATCH net v2 1/2] net: phy: Fix formatting specifier to avoid potential string cuts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z9roLbRN7Dyf22G2@smile.fi.intel.com>
Date: Wed, 19 Mar 2025 17:52:13 +0200
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: kernel test robot <lkp@...el.com>
Cc: linux-usb@...r.kernel.org, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, oe-kbuild-all@...ts.linux.dev,
	Andrew Lunn <andrew+netdev@...n.ch>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Heiner Kallweit <hkallweit1@...il.com>,
	Russell King <linux@...linux.org.uk>
Subject: Re: [PATCH net v2 1/2] net: phy: Fix formatting specifier to avoid
 potential string cuts

On Wed, Mar 19, 2025 at 11:37:19PM +0800, kernel test robot wrote:
> Hi Andy,
> 
> kernel test robot noticed the following build warnings:
> 
> [auto build test WARNING on net/main]
> 
> url:    https://github.com/intel-lab-lkp/linux/commits/Andy-Shevchenko/net-phy-Fix-formatting-specifier-to-avoid-potential-string-cuts/20250319-190433
> base:   net/main
> patch link:    https://lore.kernel.org/r/20250319105813.3102076-2-andriy.shevchenko%40linux.intel.com
> patch subject: [PATCH net v2 1/2] net: phy: Fix formatting specifier to avoid potential string cuts
> config: x86_64-allmodconfig (https://download.01.org/0day-ci/archive/20250319/202503192340.iVN44lM2-lkp@intel.com/config)
> compiler: clang version 20.1.0 (https://github.com/llvm/llvm-project 24a30daaa559829ad079f2ff7f73eb4e18095f88)
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250319/202503192340.iVN44lM2-lkp@intel.com/reproduce)
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@...el.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202503192340.iVN44lM2-lkp@intel.com/
> 
> All warnings (new ones prefixed by >>):
> 
> >> drivers/net/usb/ax88172a.c:312:20: warning: format specifies type 'unsigned char' but the argument has type 'u16' (aka 'unsigned short') [-Wformat]
>      311 |         snprintf(priv->phy_name, 20, PHY_ID_FMT,
>          |                                      ~~~~~~~~~~
>      312 |                  priv->mdio->id, priv->phy_addr);
>          |                                  ^~~~~~~~~~~~~~
>    1 warning generated.

It's fun: while working around GCC complain, clang does not agree with... :-)
Let's wait more, probably the simplest fix (if this becomes only a single user
of the non-byte parameter) is to move it to u8.

-- 
With Best Regards,
Andy Shevchenko