linux-kernel - Re: [PATCH net v2 1/2] net: phy: Fix formatting specifier to avoid potential string cuts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z9rm6NYEQpbo4-pz@shell.armlinux.org.uk>
Date: Wed, 19 Mar 2025 15:46:48 +0000
From: "Russell King (Oracle)" <linux@...linux.org.uk>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: linux-usb@...r.kernel.org, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, Andrew Lunn <andrew+netdev@...n.ch>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Heiner Kallweit <hkallweit1@...il.com>
Subject: Re: [PATCH net v2 1/2] net: phy: Fix formatting specifier to avoid
 potential string cuts

On Wed, Mar 19, 2025 at 12:54:33PM +0200, Andy Shevchenko wrote:
> -#define PHY_ID_FMT "%s:%02x"
> +#define PHY_ID_FMT "%s:%02hhx"

I was going to state whether it is correct to use hh with an "int"
argument, as printf() suggests its only for use with arguments of
type 'signed char' and 'unsigned char'. My suspicion has been
confirmed by the warning the kbuild bot has just reported.

It seems this is not a correct fix for the problem you report.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!